Re: [Qemu-devel] [PATCH v3 3/4] qdev: Simplify the SysBusDeviceClass::init path

2018-05-07 Thread Eduardo Habkost
On Fri, Apr 20, 2018 at 09:22:55AM +0200, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > > > On 04/19/2018 06:27 PM, Philippe Mathieu-Daudé wrote: > >> The SysBusDevice is the last DeviceClass::init user. > >> > >> Instead of using > >> SysBusDeviceClass::realize > >>-> Device

Re: [Qemu-devel] [PATCH v3 3/4] qdev: Simplify the SysBusDeviceClass::init path

2018-04-24 Thread Yoni Bettan
On 04/20/2018 12:27 AM, Philippe Mathieu-Daudé wrote: The SysBusDevice is the last DeviceClass::init user. Instead of using SysBusDeviceClass::realize -> DeviceClass::realize -> DeviceClass::init -> sysbus_device_init -> SysBusDeviceClass::init Simpli

Re: [Qemu-devel] [PATCH v3 3/4] qdev: Simplify the SysBusDeviceClass::init path

2018-04-20 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 04/19/2018 06:27 PM, Philippe Mathieu-Daudé wrote: >> The SysBusDevice is the last DeviceClass::init user. >> >> Instead of using >> SysBusDeviceClass::realize >>-> DeviceClass::realize >>-> DeviceClass::init >>-> sysbus_device_init >

Re: [Qemu-devel] [PATCH v3 3/4] qdev: Simplify the SysBusDeviceClass::init path

2018-04-19 Thread Philippe Mathieu-Daudé
On 04/19/2018 06:27 PM, Philippe Mathieu-Daudé wrote: > The SysBusDevice is the last DeviceClass::init user. > > Instead of using > SysBusDeviceClass::realize >-> DeviceClass::realize >-> DeviceClass::init >-> sysbus_device_init > -> SysBusDeviceClass::init

[Qemu-devel] [PATCH v3 3/4] qdev: Simplify the SysBusDeviceClass::init path

2018-04-19 Thread Philippe Mathieu-Daudé
The SysBusDevice is the last DeviceClass::init user. Instead of using SysBusDeviceClass::realize -> DeviceClass::realize -> DeviceClass::init -> sysbus_device_init -> SysBusDeviceClass::init Simplify the path by directly calling SysBusDeviceClass::init in SysB