> -dolog ("wav_fini_out: fclose %p failed\nReason: %s\n",
> > > > - wav->f, strerror (errno));
> > > > +dolog ("wav_fini_out: fclose 'wav->f' failed\nReason: %s\n",
> > > > + strerror (errno));
> > >
> > > I would just drop the 'wav->f' here.
> >
> > Or d
t; Subject: Re: [Qemu-devel] [PATCH v3 3/4] audio: Fix using freed pointer in
> wav_fini_out()
>
> Hi,
>
> > > doclose:
> > > if (fclose (wav->f)) {
> > > -dolog ("wav_fini_out: fclose %p failed\nReason: %s\n",
> > > -
Hi,
> > doclose:
> > if (fclose (wav->f)) {
> > -dolog ("wav_fini_out: fclose %p failed\nReason: %s\n",
> > - wav->f, strerror (errno));
> > +dolog ("wav_fini_out: fclose 'wav->f' failed\nReason: %s\n",
> > + strerror (errno));
>
> I would just
On 10 June 2014 10:20, wrote:
> From: Gonglei
>
> Spotted by Coverity:
>
> (8) Event freed_arg: "fclose(FILE *)" frees "wav->f".
> (9) Event cond_true: Condition "fclose(wav->f)", taking true branch
> Also see events: [pass_freed_arg]
>
> 212 if (fclose (wav->f)) {
> (10) Event pass_
From: Gonglei
Spotted by Coverity:
(8) Event freed_arg: "fclose(FILE *)" frees "wav->f".
(9) Event cond_true: Condition "fclose(wav->f)", taking true branch
Also see events: [pass_freed_arg]
212 if (fclose (wav->f)) {
(10) Event pass_freed_arg: Passing freed pointer "wav->f" as an
