Re: [Qemu-devel] [PATCH v3 3/4] Fixes RTC bug with base datetime shifts in clock=vm

2018-10-18 Thread Paolo Bonzini
On 18/10/2018 09:12, Artem Pisarenko wrote: > +rtc_host_datetime_offset = rtc_ref_start_datetime - rtc_start_datetime; > +rtc_ref_start_datetime = rtc_start_datetime; Because of this, multiple rtc options have funny effects. Can squash this instead: diff --git a/vl.c b/vl.c index 1b349b7

[Qemu-devel] [PATCH v3 3/4] Fixes RTC bug with base datetime shifts in clock=vm

2018-10-18 Thread Artem Pisarenko
This makes all current "-rtc" option parameters combinations produce fixed/unambiguous RTC timedate reference for hardware emulation frontends. It restores determinism of guest execution when used with clock=vm and specified base value. Buglink: https://bugs.launchpad.net/qemu/+bug/1797033 Signed