On 02/24/2018 06:56 AM, 苏航 wrote:
Hi, when I try to change
`while (cond) ;`
to
`while (cond) {
}`
checkpatch.pl complains about this:
'''
ERROR: suspect code indent for conditional statements (8, 8)
#1506: FILE: uri.c:1506:
+while ((*tmp++ = *segp++) != 0) {
[...]
+}
ERROR: suspe
Hi, when I try to change
`while (cond) ;`
to
`while (cond) {
}`
checkpatch.pl complains about this:
'''
ERROR: suspect code indent for conditional statements (8, 8)
#1506: FILE: uri.c:1506:
+while ((*tmp++ = *segp++) != 0) {
[...]
+}
ERROR: suspect code indent for conditional sta
Thanks for your comments :)
I will pay more attention to what you point out.
"Eric Blake" wrote:
> On 02/23/2018 03:34 AM, Thomas Huth wrote:
> > On 23.02.2018 08:51, Su Hang wrote:
> >> Add brackets that wrap `if`, `else`, `while` that hold single
> >> statements.
> >>
> >> In order to do this, I
On 02/23/2018 03:34 AM, Thomas Huth wrote:
On 23.02.2018 08:51, Su Hang wrote:
Add brackets that wrap `if`, `else`, `while` that hold single
statements.
In order to do this, I write a simple python regex script.
Without documenting the script, no one else can reproduce this; but it's
no diff
Thanks for your reply. ^_^
I will apply all your suggestion in my next patch.
> -Original Messages-
> From: "Thomas Huth"
> Sent Time: 2018-02-23 17:34:12 (Friday)
> To: "Su Hang" , stefa...@redhat.com
> Cc: qemu-devel@nongnu.org
> Subject: Re: [Qemu
On 23.02.2018 08:51, Su Hang wrote:
> Add brackets that wrap `if`, `else`, `while` that hold single
> statements.
>
> In order to do this, I write a simple python regex script.
>
> Since then, all complaints rised by checkpatch.pl has been suppressed.
>
> Signed-off-by: Su Hang
> ---
> util/ur
Add brackets that wrap `if`, `else`, `while` that hold single
statements.
In order to do this, I write a simple python regex script.
Since then, all complaints rised by checkpatch.pl has been suppressed.
Signed-off-by: Su Hang
---
util/uri.c | 462 ++
