Re: [Qemu-devel] [PATCH v3 3/3] hw/gpio: Add in AST2600 specific implementation

2019-08-14 Thread Rashmica Gupta
Thanks for the feedback! I fixed up all the things you mentioned in v4. On Tue, 2019-08-13 at 17:31 +1000, Alexey Kardashevskiy wrote: > > On 30/07/2019 15:45, Rashmica Gupta wrote: > > The AST2600 has the same sets of 3.6v gpios as the AST2400 plus an > > addtional two sets of 1.8V gpios. > > >

Re: [Qemu-devel] [PATCH v3 3/3] hw/gpio: Add in AST2600 specific implementation

2019-08-13 Thread Alexey Kardashevskiy
On 30/07/2019 15:45, Rashmica Gupta wrote: The AST2600 has the same sets of 3.6v gpios as the AST2400 plus an addtional two sets of 1.8V gpios. Signed-off-by: Rashmica Gupta --- hw/gpio/aspeed_gpio.c | 186 +- include/hw/gpio/aspeed_gpio.h | 2 +-

[Qemu-devel] [PATCH v3 3/3] hw/gpio: Add in AST2600 specific implementation

2019-07-29 Thread Rashmica Gupta
The AST2600 has the same sets of 3.6v gpios as the AST2400 plus an addtional two sets of 1.8V gpios. Signed-off-by: Rashmica Gupta --- hw/gpio/aspeed_gpio.c | 186 +- include/hw/gpio/aspeed_gpio.h | 2 +- 2 files changed, 184 insertions(+), 4 deletions(-