Re: [Qemu-devel] [PATCH v3 26/50] target/arm: call qemu_plugin_insn_append

2019-06-17 Thread Richard Henderson
On 6/14/19 10:11 AM, Alex Bennée wrote: > From: "Emilio G. Cota" > > I considered using translator_ld* from arm_ldl_code > et al. However, note that there's a helper that also calls > arm_ldl_code, so we'd have to change that caller. We should in fact change that caller. Unfortunately, the SVC

[Qemu-devel] [PATCH v3 26/50] target/arm: call qemu_plugin_insn_append

2019-06-14 Thread Alex Bennée
From: "Emilio G. Cota" I considered using translator_ld* from arm_ldl_code et al. However, note that there's a helper that also calls arm_ldl_code, so we'd have to change that caller. In thumb's case I'm also calling plugin_insn_append directly, since we can't assume that all instructions are 16