Re: [Qemu-devel] [PATCH v3 26/32] nvdimm: save arg3 for NVDIMM device _DSM method

2015-10-19 Thread Xiao Guangrong
On 10/19/2015 03:47 PM, Michael S. Tsirkin wrote: aml_arg(3) is used many times below. Pls give it a name that makes sense (not arg3! what is it for?) Er. aml_arg(3) is just the fourth parameter of _DSM method. Will add some comments: /* * The fourth parameter (Arg3) of _DMS is a package

Re: [Qemu-devel] [PATCH v3 26/32] nvdimm: save arg3 for NVDIMM device _DSM method

2015-10-19 Thread Michael S. Tsirkin
On Mon, Oct 19, 2015 at 03:14:28PM +0800, Xiao Guangrong wrote: > > > On 10/19/2015 02:50 PM, Michael S. Tsirkin wrote: > >On Sun, Oct 11, 2015 at 11:52:58AM +0800, Xiao Guangrong wrote: > >>Check if the input Arg3 is valid then store it into dsm_in if needed > >> > >>We only do the save on NVDIM

Re: [Qemu-devel] [PATCH v3 26/32] nvdimm: save arg3 for NVDIMM device _DSM method

2015-10-19 Thread Xiao Guangrong
On 10/19/2015 02:50 PM, Michael S. Tsirkin wrote: On Sun, Oct 11, 2015 at 11:52:58AM +0800, Xiao Guangrong wrote: Check if the input Arg3 is valid then store it into dsm_in if needed We only do the save on NVDIMM device since we are not going to support any function on root device Signed-off

Re: [Qemu-devel] [PATCH v3 26/32] nvdimm: save arg3 for NVDIMM device _DSM method

2015-10-18 Thread Michael S. Tsirkin
On Sun, Oct 11, 2015 at 11:52:58AM +0800, Xiao Guangrong wrote: > Check if the input Arg3 is valid then store it into dsm_in if needed > > We only do the save on NVDIMM device since we are not going to support any > function on root device > > Signed-off-by: Xiao Guangrong > --- > hw/mem/nvdimm

[Qemu-devel] [PATCH v3 26/32] nvdimm: save arg3 for NVDIMM device _DSM method

2015-10-10 Thread Xiao Guangrong
Check if the input Arg3 is valid then store it into dsm_in if needed We only do the save on NVDIMM device since we are not going to support any function on root device Signed-off-by: Xiao Guangrong --- hw/mem/nvdimm/acpi.c | 21 - 1 file changed, 20 insertions(+), 1 deletion