Re: [Qemu-devel] [PATCH v3 23/23] pci: honor PCI_COMMAND_MASTER

2012-10-11 Thread Avi Kivity
On 10/11/2012 10:49 AM, liu ping fan wrote: > On Thu, Oct 11, 2012 at 4:34 PM, Avi Kivity wrote: >> On 10/11/2012 05:38 AM, liu ping fan wrote: >>> On Wed, Oct 10, 2012 at 12:32 AM, Avi Kivity wrote: Currently we ignore PCI_COMMAND_MASTER completely: DMA succeeds even when the bit is cl

Re: [Qemu-devel] [PATCH v3 23/23] pci: honor PCI_COMMAND_MASTER

2012-10-11 Thread liu ping fan
On Thu, Oct 11, 2012 at 4:34 PM, Avi Kivity wrote: > On 10/11/2012 05:38 AM, liu ping fan wrote: >> On Wed, Oct 10, 2012 at 12:32 AM, Avi Kivity wrote: >>> Currently we ignore PCI_COMMAND_MASTER completely: DMA succeeds even when >>> the bit is clear. >>> >>> Honor PCI_COMMAND_MASTER by inserting

Re: [Qemu-devel] [PATCH v3 23/23] pci: honor PCI_COMMAND_MASTER

2012-10-11 Thread Avi Kivity
On 10/11/2012 05:38 AM, liu ping fan wrote: > On Wed, Oct 10, 2012 at 12:32 AM, Avi Kivity wrote: >> Currently we ignore PCI_COMMAND_MASTER completely: DMA succeeds even when >> the bit is clear. >> >> Honor PCI_COMMAND_MASTER by inserting a memory region into the device's >> bus master address sp

Re: [Qemu-devel] [PATCH v3 23/23] pci: honor PCI_COMMAND_MASTER

2012-10-10 Thread liu ping fan
On Wed, Oct 10, 2012 at 12:32 AM, Avi Kivity wrote: > Currently we ignore PCI_COMMAND_MASTER completely: DMA succeeds even when > the bit is clear. > > Honor PCI_COMMAND_MASTER by inserting a memory region into the device's > bus master address space, and tying its enable status to PCI_COMMAND_MAS

[Qemu-devel] [PATCH v3 23/23] pci: honor PCI_COMMAND_MASTER

2012-10-09 Thread Avi Kivity
Currently we ignore PCI_COMMAND_MASTER completely: DMA succeeds even when the bit is clear. Honor PCI_COMMAND_MASTER by inserting a memory region into the device's bus master address space, and tying its enable status to PCI_COMMAND_MASTER. Tested using setpci -s 03 COMMAND=3 while a ping was