Re: [Qemu-devel] [PATCH v3 2/4] vmdk: Implement .bdrv_co_create callback

2018-12-07 Thread Markus Armbruster
Kevin Wolf writes: > Am 07.12.2018 um 08:10 hat Markus Armbruster geschrieben: >> This is a reasonably careful review of the QAPI-related parts, but more >> of an eye-over for the remainder. >> >> Kevin Wolf writes: >> >> > From: Fam Zheng >> > >> > This makes VMDK support blockdev-create. Th

Re: [Qemu-devel] [PATCH v3 2/4] vmdk: Implement .bdrv_co_create callback

2018-12-07 Thread Kevin Wolf
Am 07.12.2018 um 08:10 hat Markus Armbruster geschrieben: > This is a reasonably careful review of the QAPI-related parts, but more > of an eye-over for the remainder. > > Kevin Wolf writes: > > > From: Fam Zheng > > > > This makes VMDK support blockdev-create. The implementation reuses the > >

Re: [Qemu-devel] [PATCH v3 2/4] vmdk: Implement .bdrv_co_create callback

2018-12-06 Thread Markus Armbruster
This is a reasonably careful review of the QAPI-related parts, but more of an eye-over for the remainder. Kevin Wolf writes: > From: Fam Zheng > > This makes VMDK support blockdev-create. The implementation reuses the > image creation code in vmdk_co_create_opts which now acceptes a callback >

[Qemu-devel] [PATCH v3 2/4] vmdk: Implement .bdrv_co_create callback

2018-12-06 Thread Kevin Wolf
From: Fam Zheng This makes VMDK support blockdev-create. The implementation reuses the image creation code in vmdk_co_create_opts which now acceptes a callback pointer to "retrieve" BlockBackend pointers from the caller. This way we separate the logic between file/extent acquisition and initializ