Re: [Qemu-devel] [PATCH v3 2/4] configure: factor out supported flag check

2015-03-23 Thread Stefan Hajnoczi
On Mon, Mar 23, 2015 at 2:44 PM, John Snow wrote: > On 03/23/2015 09:03 AM, Stefan Hajnoczi wrote: >> >> On Thu, Mar 19, 2015 at 03:01:35PM -0400, John Snow wrote: >>> >>> +cc_has_warning_flag() { >>> +if [ "$2" != "--keep-tmpc" ]; then >>> +write_c_skeleton; >>> +fi >>> + >>>

Re: [Qemu-devel] [PATCH v3 2/4] configure: factor out supported flag check

2015-03-23 Thread Paolo Bonzini
On 23/03/2015 15:44, John Snow wrote: >> > > I just figured there was no use in rewriting the same skeleton file > unconditionally in a loop. > > The helper is used later where we do want to regenerate the skeleton. > > If you still want me to just make it unconditional, I can, but I don't > s

Re: [Qemu-devel] [PATCH v3 2/4] configure: factor out supported flag check

2015-03-23 Thread John Snow
On 03/23/2015 09:03 AM, Stefan Hajnoczi wrote: On Thu, Mar 19, 2015 at 03:01:35PM -0400, John Snow wrote: +cc_has_warning_flag() { +if [ "$2" != "--keep-tmpc" ]; then +write_c_skeleton; +fi + # Use the positive sense of the flag when testing for -Wno-wombat # suppor

Re: [Qemu-devel] [PATCH v3 2/4] configure: factor out supported flag check

2015-03-23 Thread Stefan Hajnoczi
On Thu, Mar 19, 2015 at 03:01:35PM -0400, John Snow wrote: > +cc_has_warning_flag() { > +if [ "$2" != "--keep-tmpc" ]; then > +write_c_skeleton; > +fi > + > # Use the positive sense of the flag when testing for -Wno-wombat > # support (gcc will happily accept the -Wno- for

[Qemu-devel] [PATCH v3 2/4] configure: factor out supported flag check

2015-03-19 Thread John Snow
Factor out the function that checks if a compiler flag is supported or not. Signed-off-by: John Snow --- configure | 36 ++-- 1 file changed, 22 insertions(+), 14 deletions(-) diff --git a/configure b/configure index 062df84..9a0e4ef 100755 --- a/configure +++ b/