Re: [Qemu-devel] [PATCH v3 2/2] make: load only required dependency files.

2015-08-10 Thread Michael S. Tsirkin
On Mon, Aug 10, 2015 at 11:14:50AM +0100, Peter Maydell wrote: > On 9 August 2015 at 13:20, Michael S. Tsirkin wrote: > > Still - just corious about the motivation. > > Extra whitespace in input -> extra whitespace in output, should > > be harmless in both cases, should it not? > > Yeah, I agree

Re: [Qemu-devel] [PATCH v3 2/2] make: load only required dependency files.

2015-08-10 Thread Peter Maydell
On 9 August 2015 at 13:20, Michael S. Tsirkin wrote: > Still - just corious about the motivation. > Extra whitespace in input -> extra whitespace in output, should > be harmless in both cases, should it not? Yeah, I agree that it's generally harmless. My rationale for preferring no-space-after-co

Re: [Qemu-devel] [PATCH v3 2/2] make: load only required dependency files.

2015-08-10 Thread Victor Kaplansky
On Sun, Aug 09, 2015 at 12:54:37PM +0100, Peter Maydell wrote: > On 9 August 2015 at 12:39, Michael S. Tsirkin wrote: > > On Sun, Aug 09, 2015 at 12:39:59PM +0300, Victor Kaplansky wrote: > >> -$(eval -include $(addsuffix *.d, $(sort $(dir $($v) > >> +$(eval -include $(patsubst

Re: [Qemu-devel] [PATCH v3 2/2] make: load only required dependency files.

2015-08-09 Thread Michael S. Tsirkin
On Sun, Aug 09, 2015 at 12:54:37PM +0100, Peter Maydell wrote: > On 9 August 2015 at 12:39, Michael S. Tsirkin wrote: > > On Sun, Aug 09, 2015 at 12:39:59PM +0300, Victor Kaplansky wrote: > >> -$(eval -include $(addsuffix *.d, $(sort $(dir $($v) > >> +$(eval -include $(patsubst

Re: [Qemu-devel] [PATCH v3 2/2] make: load only required dependency files.

2015-08-09 Thread Peter Maydell
On 9 August 2015 at 12:39, Michael S. Tsirkin wrote: > On Sun, Aug 09, 2015 at 12:39:59PM +0300, Victor Kaplansky wrote: >> -$(eval -include $(addsuffix *.d, $(sort $(dir $($v) >> +$(eval -include $(patsubst %.o,%.d,$(patsubst %.mo,%.d,$($v >> $(eval $v := $(filter

Re: [Qemu-devel] [PATCH v3 2/2] make: load only required dependency files.

2015-08-09 Thread Michael S. Tsirkin
On Sun, Aug 09, 2015 at 12:39:59PM +0300, Victor Kaplansky wrote: > The old rules.mak loads dependency .d files using include directive > with file glob pattern "*.d". This breaks the build when build tree has > remanent *.d files from another build. > > This patch fixes this by > - loading prec

[Qemu-devel] [PATCH v3 2/2] make: load only required dependency files.

2015-08-09 Thread Victor Kaplansky
The old rules.mak loads dependency .d files using include directive with file glob pattern "*.d". This breaks the build when build tree has remanent *.d files from another build. This patch fixes this by - loading precise list of .d files made from *.o and *.mo. - specifying explicit list of r