Re: [Qemu-devel] [PATCH v3 2/2] loader: put FW CFG ROM files into RAM

2013-08-19 Thread Michael S. Tsirkin
On Mon, Aug 19, 2013 at 01:15:36PM +0200, Laszlo Ersek wrote: > On 08/19/13 13:06, Laszlo Ersek wrote: > > On 08/13/13 00:43, Michael S. Tsirkin wrote: > > >> @@ -646,6 +669,7 @@ int rom_add_file(const char *file, const char *fw_dir, > >> if (rom->fw_file && fw_cfg) { > >> const char

Re: [Qemu-devel] [PATCH v3 2/2] loader: put FW CFG ROM files into RAM

2013-08-19 Thread Laszlo Ersek
On 08/19/13 13:06, Laszlo Ersek wrote: > On 08/13/13 00:43, Michael S. Tsirkin wrote: >> @@ -646,6 +669,7 @@ int rom_add_file(const char *file, const char *fw_dir, >> if (rom->fw_file && fw_cfg) { >> const char *basename; >> char fw_file_name[56]; >> +void *data; >>

Re: [Qemu-devel] [PATCH v3 2/2] loader: put FW CFG ROM files into RAM

2013-08-19 Thread Michael S. Tsirkin
On Mon, Aug 19, 2013 at 01:06:07PM +0200, Laszlo Ersek wrote: > On 08/13/13 00:43, Michael S. Tsirkin wrote: > > ROM files that are put in FW CFG are copied to guest ram, by BIOS, but > > they are not backed by RAM so they don't get migrated. > > Can you please elaborate on this? Do you mean the 3

Re: [Qemu-devel] [PATCH v3 2/2] loader: put FW CFG ROM files into RAM

2013-08-19 Thread Laszlo Ersek
On 08/13/13 00:43, Michael S. Tsirkin wrote: > ROM files that are put in FW CFG are copied to guest ram, by BIOS, but > they are not backed by RAM so they don't get migrated. Can you please elaborate on this? Do you mean the 384 KB range between 640KB and 1MB that is covered by RAMBlock, but no Me

[Qemu-devel] [PATCH v3 2/2] loader: put FW CFG ROM files into RAM

2013-08-12 Thread Michael S. Tsirkin
ROM files that are put in FW CFG are copied to guest ram, by BIOS, but they are not backed by RAM so they don't get migrated. Each time we change two bytes in such a ROM this breaks cross-version migration: since we can migrate after BIOS has read the first byte but before it has read the second o