Re: [Qemu-devel] [PATCH v3 2/2] block: move the bdrv_dev_change_media_cb()

2013-06-20 Thread Pavel Hrdina
On 19.6.2013 12:16, Stefan Hajnoczi wrote: On Mon, Jun 17, 2013 at 03:21:41PM +0200, Pavel Hrdina wrote: The bdrv_dev_change_media_cb() should be called only for eject and change commands. We should call that function only if that command is successful. What this function does is that it calls

Re: [Qemu-devel] [PATCH v3 2/2] block: move the bdrv_dev_change_media_cb()

2013-06-19 Thread Stefan Hajnoczi
On Mon, Jun 17, 2013 at 03:21:41PM +0200, Pavel Hrdina wrote: > The bdrv_dev_change_media_cb() should be called only for eject and change > commands. We should call that function only if that command is successful. > > What this function does is that it calls the change_media_cb() and also emit >

[Qemu-devel] [PATCH v3 2/2] block: move the bdrv_dev_change_media_cb()

2013-06-17 Thread Pavel Hrdina
The bdrv_dev_change_media_cb() should be called only for eject and change commands. We should call that function only if that command is successful. What this function does is that it calls the change_media_cb() and also emit the QEVENT_DEVICE_TRAY_MOVED event. If a password is not required, but