Re: [Qemu-devel] [PATCH v3 16/16] hw/timer: QOM'ify tusb6010

2016-02-19 Thread xiaoqiang zhao
> 在 2016年2月19日,19:37,Peter Maydell 写道: > > Mmm, I thought this might be related to the MUSB code. > I think this device cannot be converted properly to current > QOM standards until the MUSB code which it relies on has > been converted first. Reasonable !

Re: [Qemu-devel] [PATCH v3 16/16] hw/timer: QOM'ify tusb6010

2016-02-19 Thread Peter Maydell
On 19 February 2016 at 11:02, hitmoon wrote: > Hi: peter > After some debug, I found > > s->musb = musb_init(dev, 1); > > must be called in SysBus' init. Otherwise it will break the > "/arm/device/introspect/concrete" check test. Mmm, I thought this might be related to the MUSB code. I think th

Re: [Qemu-devel] [PATCH v3 16/16] hw/timer: QOM'ify tusb6010

2016-02-19 Thread hitmoon
在 2016年02月18日 21:48, Peter Maydell 写道: On 16 February 2016 at 11:10, xiaoqiang zhao wrote: assign tusb6010_init to tusb6010_info.instance_init and drop the SysBusDeviceClass::init Reviewed-by: Peter Maydell Signed-off-by: xiaoqiang zhao (Again, I didn't review this patch.) --- hw/time

Re: [Qemu-devel] [PATCH v3 16/16] hw/timer: QOM'ify tusb6010

2016-02-18 Thread zxq_yx_007
Ok, I will take a look! 2016年2月18日 星期四 +0800 21:48 发件人 peter.mayd...@linaro.org : >On 16 February 2016 at 11:10, xiaoqiang zhao < zxq_yx_...@163.com > wrote: >> assign tusb6010_init to tusb6010_info.instance_init and drop >> the SysBusDeviceClass::init >> >> Reviewed-by: Peter Maydell < peter

Re: [Qemu-devel] [PATCH v3 16/16] hw/timer: QOM'ify tusb6010

2016-02-18 Thread Peter Maydell
On 16 February 2016 at 11:10, xiaoqiang zhao wrote: > assign tusb6010_init to tusb6010_info.instance_init and drop > the SysBusDeviceClass::init > > Reviewed-by: Peter Maydell > Signed-off-by: xiaoqiang zhao (Again, I didn't review this patch.) > --- > hw/timer/tusb6010.c | 13 ++--- >

[Qemu-devel] [PATCH v3 16/16] hw/timer: QOM'ify tusb6010

2016-02-16 Thread xiaoqiang zhao
assign tusb6010_init to tusb6010_info.instance_init and drop the SysBusDeviceClass::init Reviewed-by: Peter Maydell Signed-off-by: xiaoqiang zhao --- hw/timer/tusb6010.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/hw/timer/tusb6010.c b/hw/timer/tusb6010.c i