Re: [Qemu-devel] [PATCH v3 15/19] nbd/client: Add nbd_receive_export_list()

2019-01-16 Thread Eric Blake
On 1/16/19 4:15 AM, Vladimir Sementsov-Ogievskiy wrote: >> This patch adds the low-level client code for grabbing the list >> of exports. It benefits from the recent refactoring patches, as >> well as a minor tweak of changing nbd_opt_go() to nbd_opt_info_or_go(), >> -/* Returns -1 if NBD_OPT_GO

Re: [Qemu-devel] [PATCH v3 15/19] nbd/client: Add nbd_receive_export_list()

2019-01-16 Thread Eric Blake
On 1/16/19 4:15 AM, Vladimir Sementsov-Ogievskiy wrote: >> @@ -347,7 +350,8 @@ static int nbd_opt_go(QIOChannel *ioc, NBDExportInfo >> *info, Error **errp) >>* flags still 0 is a witness of a broken server. */ >> info->flags = 0; >> >> -trace_nbd_opt_go_start(info->name); >> +

Re: [Qemu-devel] [PATCH v3 15/19] nbd/client: Add nbd_receive_export_list()

2019-01-16 Thread Vladimir Sementsov-Ogievskiy
12.01.2019 20:58, Eric Blake wrote: > We want to be able to detect whether a given qemu NBD server is > exposing the right export(s) and dirty bitmaps, at least for > regression testing. We could use 'nbd-client -l' from the upstream > NBD project to list exports, but it's annoying to rely on > ou

[Qemu-devel] [PATCH v3 15/19] nbd/client: Add nbd_receive_export_list()

2019-01-12 Thread Eric Blake
We want to be able to detect whether a given qemu NBD server is exposing the right export(s) and dirty bitmaps, at least for regression testing. We could use 'nbd-client -l' from the upstream NBD project to list exports, but it's annoying to rely on out-of-tree binaries; furthermore, nbd-client do