Re: [Qemu-devel] [PATCH v3 15/18] ucontext: annotate coroutine stack for ASAN

2018-01-12 Thread Paolo Bonzini
On 12/01/2018 12:15, Marc-André Lureau wrote: >>> You simply need to update the .travis.yml, but does that mean your >> I think we need libgcc-6-dev. >> >>> previous patch "Enable ASAN/UBSan by default if the compiler supports >>> it." isn't correct? >> No, the problematic patch is "ucontext: annot

Re: [Qemu-devel] [PATCH v3 15/18] ucontext: annotate coroutine stack for ASAN

2018-01-12 Thread Marc-André Lureau
Hi, On Tue, Jan 9, 2018 at 12:23 PM, Marc-André Lureau wrote: > Hi > > On Tue, Jan 9, 2018 at 12:09 PM, Philippe Mathieu-Daudé > wrote: >> Hi Marc-André, >> >> On 01/04/2018 01:05 PM, Marc-André Lureau wrote: >>> It helps ASAN to detect more leaks on coroutine stacks, as found in >>> the follow

Re: [Qemu-devel] [PATCH v3 15/18] ucontext: annotate coroutine stack for ASAN

2018-01-09 Thread Marc-André Lureau
Hi On Tue, Jan 9, 2018 at 12:09 PM, Philippe Mathieu-Daudé wrote: > Hi Marc-André, > > On 01/04/2018 01:05 PM, Marc-André Lureau wrote: >> It helps ASAN to detect more leaks on coroutine stacks, as found in >> the following patch. >> >> A similar work would need to be done for sigaltstack & windo

Re: [Qemu-devel] [PATCH v3 15/18] ucontext: annotate coroutine stack for ASAN

2018-01-09 Thread Philippe Mathieu-Daudé
> On 01/04/2018 01:05 PM, Marc-André Lureau wrote: >> It helps ASAN to detect more leaks on coroutine stacks, as found in >> the following patch. >> >> A similar work would need to be done for sigaltstack & windows fibers >> to have similar coverage. Since ucontext is preferred, I didn't bother >>

Re: [Qemu-devel] [PATCH v3 15/18] ucontext: annotate coroutine stack for ASAN

2018-01-09 Thread Philippe Mathieu-Daudé
Hi Marc-André, On 01/04/2018 01:05 PM, Marc-André Lureau wrote: > It helps ASAN to detect more leaks on coroutine stacks, as found in > the following patch. > > A similar work would need to be done for sigaltstack & windows fibers > to have similar coverage. Since ucontext is preferred, I didn't

[Qemu-devel] [PATCH v3 15/18] ucontext: annotate coroutine stack for ASAN

2018-01-04 Thread Marc-André Lureau
It helps ASAN to detect more leaks on coroutine stacks, as found in the following patch. A similar work would need to be done for sigaltstack & windows fibers to have similar coverage. Since ucontext is preferred, I didn't bother checking the other coroutine implementations for now. Signed-off-by