Re: [Qemu-devel] [PATCH v3 10/10] palmetto-bmc: remove extra no_sdcard assignement

2016-08-11 Thread Peter Maydell
On 2 August 2016 at 18:15, Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater > --- > hw/arm/aspeed.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c > index e71500c64bd3..6d7b70df70da 100644 > --- a/hw/arm/aspeed.c > +++ b/hw/arm/aspeed.c > @@ -1

Re: [Qemu-devel] [PATCH v3 10/10] palmetto-bmc: remove extra no_sdcard assignement

2016-08-03 Thread Cédric Le Goater
On 08/03/2016 02:23 AM, Andrew Jeffery wrote: > On Tue, 2016-08-02 at 19:15 +0200, Cédric Le Goater wrote: >> Signed-off-by: Cédric Le Goater > > Reviewed-by: Andrew Jeffery Thanks for the overall review Andrew, C. >> --- >> hw/arm/aspeed.c | 1 - >> 1 file changed, 1 deletion(-) >> >> di

Re: [Qemu-devel] [PATCH v3 10/10] palmetto-bmc: remove extra no_sdcard assignement

2016-08-02 Thread Andrew Jeffery
On Tue, 2016-08-02 at 19:15 +0200, Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater Reviewed-by: Andrew Jeffery > --- >  hw/arm/aspeed.c | 1 - >  1 file changed, 1 deletion(-) > > diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c > index e71500c64bd3..6d7b70df70da 100644 > --- a/hw/arm/a

[Qemu-devel] [PATCH v3 10/10] palmetto-bmc: remove extra no_sdcard assignement

2016-08-02 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/arm/aspeed.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index e71500c64bd3..6d7b70df70da 100644 --- a/hw/arm/aspeed.c +++ b/hw/arm/aspeed.c @@ -145,7 +145,6 @@ static void palmetto_bmc_class_init(ObjectClass *oc, voi