Re: [Qemu-devel] [PATCH v3 1/8] target-ppc: Add helper for KVM_PPC_RTAS_DEFINE_TOKEN

2013-08-30 Thread Alexander Graf
On 31.08.2013, at 00:19, Benjamin Herrenschmidt wrote: > On Fri, 2013-08-30 at 16:34 +0200, Alexander Graf wrote: > >>> So - kvmppc_define_rtas_in_kernel() or kvmppc_define_rtas_kernel_token()? >> >> The former probably. > > I told him the latter :-) Honestly, your name is gross :-) Mine > des

Re: [Qemu-devel] [PATCH v3 1/8] target-ppc: Add helper for KVM_PPC_RTAS_DEFINE_TOKEN

2013-08-30 Thread Benjamin Herrenschmidt
On Fri, 2013-08-30 at 16:34 +0200, Alexander Graf wrote: > > So - kvmppc_define_rtas_in_kernel() or kvmppc_define_rtas_kernel_token()? > > The former probably. I told him the latter :-) Honestly, your name is gross :-) Mine describes exactly what the calls does. > > I would actually though that

Re: [Qemu-devel] [PATCH v3 1/8] target-ppc: Add helper for KVM_PPC_RTAS_DEFINE_TOKEN

2013-08-30 Thread Laszlo Ersek
Hello Benjamin, On 08/27/13 02:43, Benjamin Herrenschmidt wrote: > Am I dreaming ? Those patches were written about a year ago and you guys > are still nitpicking on names ? They should have been merged a LONG time > ago ... > > I'm seriously wondering how people get anything done with qemu KVM

Re: [Qemu-devel] [PATCH v3 1/8] target-ppc: Add helper for KVM_PPC_RTAS_DEFINE_TOKEN

2013-08-30 Thread Alexander Graf
On 29.08.2013, at 10:18, Alexey Kardashevskiy wrote: > On 08/27/2013 06:36 PM, Alexander Graf wrote: >> >> On 27.08.2013, at 06:10, Benjamin Herrenschmidt wrote: >> >>> On Tue, 2013-08-27 at 03:48 +0200, Andreas Färber wrote: Also, QEMU is definitely not the only project that has higher >>

Re: [Qemu-devel] [PATCH v3 1/8] target-ppc: Add helper for KVM_PPC_RTAS_DEFINE_TOKEN

2013-08-29 Thread Alexey Kardashevskiy
On 08/27/2013 06:36 PM, Alexander Graf wrote: > > On 27.08.2013, at 06:10, Benjamin Herrenschmidt wrote: > >> On Tue, 2013-08-27 at 03:48 +0200, Andreas Färber wrote: >>> Also, QEMU is definitely not the only project that has higher >>> acceptance >>> criteria than patch-works-for-the-patch-autho

Re: [Qemu-devel] [PATCH v3 1/8] target-ppc: Add helper for KVM_PPC_RTAS_DEFINE_TOKEN

2013-08-27 Thread Alexander Graf
On 27.08.2013, at 06:10, Benjamin Herrenschmidt wrote: > On Tue, 2013-08-27 at 03:48 +0200, Andreas Färber wrote: >> Also, QEMU is definitely not the only project that has higher >> acceptance >> criteria than patch-works-for-the-patch-author. :) > > There's a difference between high acceptance

Re: [Qemu-devel] [PATCH v3 1/8] target-ppc: Add helper for KVM_PPC_RTAS_DEFINE_TOKEN

2013-08-26 Thread Benjamin Herrenschmidt
On Tue, 2013-08-27 at 03:48 +0200, Andreas Färber wrote: > Also, QEMU is definitely not the only project that has higher > acceptance > criteria than patch-works-for-the-patch-author. :) There's a difference between high acceptance criteria and systematic bike shed painting including in some case

Re: [Qemu-devel] [PATCH v3 1/8] target-ppc: Add helper for KVM_PPC_RTAS_DEFINE_TOKEN

2013-08-26 Thread Andreas Färber
Am 27.08.2013 02:43, schrieb Benjamin Herrenschmidt: > Am I dreaming ? Those patches were written about a year ago and you guys > are still nitpicking on names ? They should have been merged a LONG time > ago ... [snip] Ben, this patch was first posted to qemu-devel June 4th, this year. If patche

Re: [Qemu-devel] [PATCH v3 1/8] target-ppc: Add helper for KVM_PPC_RTAS_DEFINE_TOKEN

2013-08-26 Thread Benjamin Herrenschmidt
On Mon, 2013-08-26 at 15:11 +0200, Alexander Graf wrote: > On 19.08.2013, at 07:55, Alexey Kardashevskiy wrote: > > > From: David Gibson > > > > Recent PowerKVM allows the kernel to intercept some RTAS calls from > the > > guest directly. This is used to implement the more efficient > in-kernel

Re: [Qemu-devel] [PATCH v3 1/8] target-ppc: Add helper for KVM_PPC_RTAS_DEFINE_TOKEN

2013-08-26 Thread Alexander Graf
On 19.08.2013, at 07:55, Alexey Kardashevskiy wrote: > From: David Gibson > > Recent PowerKVM allows the kernel to intercept some RTAS calls from the > guest directly. This is used to implement the more efficient in-kernel > XICS for example. qemu is still responsible for assigning the RTAS t

[Qemu-devel] [PATCH v3 1/8] target-ppc: Add helper for KVM_PPC_RTAS_DEFINE_TOKEN

2013-08-18 Thread Alexey Kardashevskiy
From: David Gibson Recent PowerKVM allows the kernel to intercept some RTAS calls from the guest directly. This is used to implement the more efficient in-kernel XICS for example. qemu is still responsible for assigning the RTAS token numbers however, and needs to tell the kernel which RTAS fun