Hi,
> > >
> > >> > Yoda conditions lack readability, and QEMU has a
> > >> > strict compiler configuration for checking a common
> > >> > mistake like "if (dev = NULL)". Make it a written rule.
> >
> > >>
> > >> I know this is my suggested text, but now that I'm re-reading it, I'd
> > >> recommen
On Tue, Aug 05, 2014 at 04:48:18PM +0100, Alex Bennée wrote:
>
> Gonglei (Arei) writes:
>
> > Hi,
> >
> >> > Yoda conditions lack readability, and QEMU has a
> >> > strict compiler configuration for checking a common
> >> > mistake like "if (dev = NULL)". Make it a written rule.
>
> >>
> >> I k
Gonglei (Arei) writes:
> Hi,
>
>> > Yoda conditions lack readability, and QEMU has a
>> > strict compiler configuration for checking a common
>> > mistake like "if (dev = NULL)". Make it a written rule.
>>
>> I know this is my suggested text, but now that I'm re-reading it, I'd
>> recommend s/0
Hi,
> > Yoda conditions lack readability, and QEMU has a
> > strict compiler configuration for checking a common
> > mistake like "if (dev = NULL)". Make it a written rule.
> >
> > Signed-off-by: Gonglei
> > ---
> > CODING_STYLE | 14 ++
> > 1 file changed, 14 insertions(+)
> >
> > d
On 08/01/2014 01:46 AM, arei.gong...@huawei.com wrote:
> From: Gonglei
>
> Yoda conditions lack readability, and QEMU has a
> strict compiler configuration for checking a common
> mistake like "if (dev = NULL)". Make it a written rule.
>
> Signed-off-by: Gonglei
> ---
> CODING_STYLE | 14 +
From: Gonglei
Yoda conditions lack readability, and QEMU has a
strict compiler configuration for checking a common
mistake like "if (dev = NULL)". Make it a written rule.
Signed-off-by: Gonglei
---
CODING_STYLE | 14 ++
1 file changed, 14 insertions(+)
diff --git a/CODING_STYLE b/
