Re: [Qemu-devel] [PATCH v3 1/6] pc: Move compat boolean globals to PCMachineClass

2015-12-02 Thread Marcel Apfelbaum
On 12/02/2015 11:57 AM, Marcel Apfelbaum wrote: On 12/02/2015 12:58 AM, Eduardo Habkost wrote: This way the compat flags can be initialized in the machine_options() function. This will help us to eventually eliminate the pc_compat_*() functions. Hi, I have only a minor comment here, Signed-

Re: [Qemu-devel] [PATCH v3 1/6] pc: Move compat boolean globals to PCMachineClass

2015-12-02 Thread Marcel Apfelbaum
On 12/02/2015 12:58 AM, Eduardo Habkost wrote: This way the compat flags can be initialized in the machine_options() function. This will help us to eventually eliminate the pc_compat_*() functions. Hi, I have only a minor comment here, Signed-off-by: Eduardo Habkost --- hw/i386/pc.c

[Qemu-devel] [PATCH v3 1/6] pc: Move compat boolean globals to PCMachineClass

2015-12-01 Thread Eduardo Habkost
This way the compat flags can be initialized in the machine_options() function. This will help us to eventually eliminate the pc_compat_*() functions. Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 8 + hw/i386/pc_piix.c| 84 +--