Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-16 Thread Markus Armbruster
Wen Congyang writes: > On 09/16/2015 07:18 PM, Markus Armbruster wrote: >> Wen Congyang writes: >> >>> On 09/16/2015 04:21 PM, Markus Armbruster wrote: Wen Congyang writes: > On 09/15/2015 07:12 PM, Markus Armbruster wrote: >> Wen Congyang writes: >> >>> On 09/15/201

Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-16 Thread Wen Congyang
On 09/16/2015 07:18 PM, Markus Armbruster wrote: > Wen Congyang writes: > >> On 09/16/2015 04:21 PM, Markus Armbruster wrote: >>> Wen Congyang writes: >>> On 09/15/2015 07:12 PM, Markus Armbruster wrote: > Wen Congyang writes: > >> On 09/15/2015 03:37 PM, Markus Armbruster wrot

Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-16 Thread Eric Blake
On 09/16/2015 01:11 AM, Wen Congyang wrote: Possible workaround in the meantime - instead of trying to go with a nice flat union (where all QMP keys are in the same {} level), we can use nesting (structs that add another {} to include the unions). >>> >>> How to include the unions t

Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-16 Thread Markus Armbruster
Wen Congyang writes: > On 09/16/2015 04:21 PM, Markus Armbruster wrote: >> Wen Congyang writes: >> >>> On 09/15/2015 07:12 PM, Markus Armbruster wrote: Wen Congyang writes: > On 09/15/2015 03:37 PM, Markus Armbruster wrote: >> Wen Congyang writes: >> >>> On 09/14/201

Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-16 Thread Wen Congyang
On 09/16/2015 04:21 PM, Markus Armbruster wrote: > Wen Congyang writes: > >> On 09/15/2015 07:12 PM, Markus Armbruster wrote: >>> Wen Congyang writes: >>> On 09/15/2015 03:37 PM, Markus Armbruster wrote: > Wen Congyang writes: > >> On 09/14/2015 11:47 PM, Eric Blake wrote:

Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-16 Thread Markus Armbruster
Wen Congyang writes: > On 09/15/2015 07:12 PM, Markus Armbruster wrote: >> Wen Congyang writes: >> >>> On 09/15/2015 03:37 PM, Markus Armbruster wrote: Wen Congyang writes: > On 09/14/2015 11:47 PM, Eric Blake wrote: >> On 09/14/2015 08:27 AM, Markus Armbruster wrote: >>>

Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-16 Thread Wen Congyang
On 09/15/2015 09:11 PM, Eric Blake wrote: > On 09/14/2015 09:58 PM, Wen Congyang wrote: >> On 09/15/2015 11:46 AM, Eric Blake wrote: >>> On 09/14/2015 08:27 PM, Wen Congyang wrote: > Building fails: > GEN qmp-commands.h > In file included from /work/src/qemu/qapi-schema.json:9:

Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-15 Thread Wen Congyang
On 09/15/2015 07:12 PM, Markus Armbruster wrote: > Wen Congyang writes: > >> On 09/15/2015 03:37 PM, Markus Armbruster wrote: >>> Wen Congyang writes: >>> On 09/14/2015 11:47 PM, Eric Blake wrote: > On 09/14/2015 08:27 AM, Markus Armbruster wrote: >> Wen Congyang writes: >> >>>

Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-15 Thread Kevin Wolf
Am 15.09.2015 um 15:03 hat Eric Blake geschrieben: > On 09/15/2015 01:37 AM, Markus Armbruster wrote: > > > +# @filename: #optional unix or inet path. The format is: > > +#unix: nbd+unix:///export?socket=path or > > +# nbd:unix:path:exportname=export >

Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-15 Thread Eric Blake
On 09/15/2015 01:37 AM, Markus Armbruster wrote: > +# @filename: #optional unix or inet path. The format is: > +#unix: nbd+unix:///export?socket=path or > +# nbd:unix:path:exportname=export > +#inet: nbd[+tcp]://host[:port]/export or > +

Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-15 Thread Eric Blake
On 09/14/2015 09:58 PM, Wen Congyang wrote: > On 09/15/2015 11:46 AM, Eric Blake wrote: >> On 09/14/2015 08:27 PM, Wen Congyang wrote: Building fails: GEN qmp-commands.h In file included from /work/src/qemu/qapi-schema.json:9: In file included from /work/src/qemu/qapi/block.

Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-15 Thread Markus Armbruster
Wen Congyang writes: > On 09/15/2015 03:37 PM, Markus Armbruster wrote: >> Wen Congyang writes: >> >>> On 09/14/2015 11:47 PM, Eric Blake wrote: On 09/14/2015 08:27 AM, Markus Armbruster wrote: > Wen Congyang writes: > >> The NBD driver needs: filename, path or (host, port, ex

Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-15 Thread Wen Congyang
On 09/15/2015 03:37 PM, Markus Armbruster wrote: > Wen Congyang writes: > >> On 09/14/2015 11:47 PM, Eric Blake wrote: >>> On 09/14/2015 08:27 AM, Markus Armbruster wrote: Wen Congyang writes: > The NBD driver needs: filename, path or (host, port, exportname). > It checks which

Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-15 Thread Markus Armbruster
Wen Congyang writes: > On 09/14/2015 11:47 PM, Eric Blake wrote: >> On 09/14/2015 08:27 AM, Markus Armbruster wrote: >>> Wen Congyang writes: >>> The NBD driver needs: filename, path or (host, port, exportname). It checks which key exists and decides use unix or inet socket. It do

Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-14 Thread Wen Congyang
On 09/15/2015 11:46 AM, Eric Blake wrote: > On 09/14/2015 08:27 PM, Wen Congyang wrote: >>> Building fails: >>> GEN qmp-commands.h >>> In file included from /work/src/qemu/qapi-schema.json:9: >>> In file included from /work/src/qemu/qapi/block.json:6: >>> /work/src/qemu/qapi/block-core.json:184

Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-14 Thread Eric Blake
On 09/14/2015 08:27 PM, Wen Congyang wrote: >> Building fails: >> GEN qmp-commands.h >> In file included from /work/src/qemu/qapi-schema.json:9: >> In file included from /work/src/qemu/qapi/block.json:6: >> /work/src/qemu/qapi/block-core.json:1844: Flat union 'BlockdevOptionsNBD' >> must have

Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-14 Thread Wen Congyang
On 09/15/2015 10:20 AM, Wen Congyang wrote: > On 09/14/2015 11:47 PM, Eric Blake wrote: >> On 09/14/2015 08:27 AM, Markus Armbruster wrote: >>> Wen Congyang writes: >>> The NBD driver needs: filename, path or (host, port, exportname). It checks which key exists and decides use unix or in

Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-14 Thread Wen Congyang
On 09/14/2015 11:47 PM, Eric Blake wrote: > On 09/14/2015 08:27 AM, Markus Armbruster wrote: >> Wen Congyang writes: >> >>> The NBD driver needs: filename, path or (host, port, exportname). >>> It checks which key exists and decides use unix or inet socket. >>> It doesn't recognize the key type, s

Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-14 Thread Wen Congyang
On 09/14/2015 11:47 PM, Eric Blake wrote: > On 09/14/2015 08:27 AM, Markus Armbruster wrote: >> Wen Congyang writes: >> >>> The NBD driver needs: filename, path or (host, port, exportname). >>> It checks which key exists and decides use unix or inet socket. >>> It doesn't recognize the key type, s

Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-14 Thread Eric Blake
On 09/14/2015 08:27 AM, Markus Armbruster wrote: > Wen Congyang writes: > >> The NBD driver needs: filename, path or (host, port, exportname). >> It checks which key exists and decides use unix or inet socket. >> It doesn't recognize the key type, so we can't use union, and >> can't reuse InetSoc

Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-14 Thread Markus Armbruster
Wen Congyang writes: > The NBD driver needs: filename, path or (host, port, exportname). > It checks which key exists and decides use unix or inet socket. > It doesn't recognize the key type, so we can't use union, and > can't reuse InetSocketAddress. > > Signed-off-by: Wen Congyang > Signed-off

[Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-10 Thread Wen Congyang
The NBD driver needs: filename, path or (host, port, exportname). It checks which key exists and decides use unix or inet socket. It doesn't recognize the key type, so we can't use union, and can't reuse InetSocketAddress. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: G