Re: [Qemu-devel] [PATCH v3 1/4] qemu-io: Don't die on second open

2017-06-06 Thread Kevin Wolf
Am 05.06.2017 um 21:58 hat Eric Blake geschrieben: > Also, I'm seeing a segfault on 68 that exists on current master: > > 068 1s ... - output mismatch (see 068.out.bad) > --- /home/eblake/qemu/tests/qemu-iotests/068.out 2017-06-01 > 17:01:25.113094957 -0500 > +++ 068.out.bad 2017-06-05

Re: [Qemu-devel] [PATCH v3 1/4] qemu-io: Don't die on second open

2017-06-05 Thread Eric Blake
On 06/05/2017 02:08 PM, Eric Blake wrote: > > Note, however, that we do have some qemu-iotests that do 'qemu-io > -c "open file" -c "$something"'; such tests will now proceed to > attempt $something whether or not the open succeeded, the same way > as if the two commands had been attempted in int

[Qemu-devel] [PATCH v3 1/4] qemu-io: Don't die on second open

2017-06-05 Thread Eric Blake
Most callback commands in qemu-io return 0 to keep the interpreter loop running, or 1 to quit immediately. However, open_f() just passed through the return value of openfile(), which has different semantics of returning 0 if a file was opened, or 1 on any failure. As a result of mixing the return