Re: [Qemu-devel] [PATCH v3 1/3] blkdebug: fix one shot rule processing

2019-01-11 Thread Max Reitz
On 12.11.18 08:06, Marc Olson wrote: > If 'once' is specified, the rule should execute just once, regardless if > it is supposed to return an error or not. Take the example where you > want the first IO to an LBA to succeed, but subsequent IOs to fail. You > could either use state transitions, or c

Re: [Qemu-devel] [PATCH v3 1/3] blkdebug: fix one shot rule processing

2018-11-13 Thread John Snow
On 11/12/18 2:06 AM, Marc Olson via Qemu-devel wrote: > If 'once' is specified, the rule should execute just once, regardless if > it is supposed to return an error or not. Take the example where you > want the first IO to an LBA to succeed, but subsequent IOs to fail. You > could either use sta

Re: [Qemu-devel] [PATCH v3 1/3] blkdebug: fix one shot rule processing

2018-11-12 Thread Dongli Zhang
Hi Marc, When I play with the v3 patch set, the qemu hangs again and I need to kill it with "kill -9". I got below from guest: [ 104.828127] nvme nvme0: I/O 52 QID 1 timeout, aborting [ 104.828470] nvme nvme0: Abort status: 0x4001 nvme abort is not supported by qemu and therefore 0x4001 (NVME

[Qemu-devel] [PATCH v3 1/3] blkdebug: fix one shot rule processing

2018-11-11 Thread Marc Olson via Qemu-devel
If 'once' is specified, the rule should execute just once, regardless if it is supposed to return an error or not. Take the example where you want the first IO to an LBA to succeed, but subsequent IOs to fail. You could either use state transitions, or create two rules, one with error = 0 and once