Re: [Qemu-devel] [PATCH v3 1/1] char/serial: Fix emptyness handling

2014-04-07 Thread Peter Maydell
On 4 April 2014 13:13, Peter Crosthwaite wrote: > On Fri, Mar 28, 2014 at 10:10 PM, Paolo Bonzini wrote: >> Il 28/03/2014 12:43, Don Slutz ha scritto: >> >>> Ping. (Since this is a bug fix, I think it can go into 2.0) >>> -Don Slutz >> >> >> I think the problem is that not many people unders

Re: [Qemu-devel] [PATCH v3 1/1] char/serial: Fix emptyness handling

2014-04-04 Thread Peter Crosthwaite
On Fri, Mar 28, 2014 at 10:10 PM, Paolo Bonzini wrote: > Il 28/03/2014 12:43, Don Slutz ha scritto: > >> Ping. (Since this is a bug fix, I think it can go into 2.0) >> -Don Slutz > > > I think the problem is that not many people understand the 8250 device > model. CCing someone who hopefully

Re: [Qemu-devel] [PATCH v3 1/1] char/serial: Fix emptyness handling

2014-03-28 Thread Paolo Bonzini
Il 28/03/2014 12:43, Don Slutz ha scritto: Ping. (Since this is a bug fix, I think it can go into 2.0) -Don Slutz I think the problem is that not many people understand the 8250 device model. CCing someone who hopefully does... Paolo On 03/18/14 12:29, Don Slutz wrote: The commit 88

Re: [Qemu-devel] [PATCH v3 1/1] char/serial: Fix emptyness handling

2014-03-28 Thread Don Slutz
Ping. (Since this is a bug fix, I think it can go into 2.0) -Don Slutz On 03/18/14 12:29, Don Slutz wrote: The commit 88c1ee73d3231c74ff90bcfc084a7589670ec244 char/serial: Fix emptyness check Still causes extra NULL byte(s) to be sent. So if the fifo is empty, do not send an extra NULL by

[Qemu-devel] [PATCH v3 1/1] char/serial: Fix emptyness handling

2014-03-18 Thread Don Slutz
The commit 88c1ee73d3231c74ff90bcfc084a7589670ec244 char/serial: Fix emptyness check Still causes extra NULL byte(s) to be sent. So if the fifo is empty, do not send an extra NULL byte. Reviewed-by: Peter Crosthwaite Signed-off-by: Don Slutz --- Changes V2 to v3 Revert v2 changes Fix codin