Re: [Qemu-devel] [PATCH v3 1/1] atapi: abort transfers with 0 byte limits

2015-09-16 Thread John Snow
On 09/16/2015 11:09 AM, Markus Armbruster wrote: > John Snow writes: > >> On 09/15/2015 04:06 AM, Markus Armbruster wrote: >>> John Snow writes: >>> We're supposed to abort on transfers like this, unless we fill Word 125 of our IDENTIFY data with a default transfer size, which w

Re: [Qemu-devel] [PATCH v3 1/1] atapi: abort transfers with 0 byte limits

2015-09-16 Thread Markus Armbruster
John Snow writes: > On 09/15/2015 04:06 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> We're supposed to abort on transfers like this, unless we fill >>> Word 125 of our IDENTIFY data with a default transfer size, which >>> we don't currently do. >>> >>> This is an ATA error, not a SC

Re: [Qemu-devel] [PATCH v3 1/1] atapi: abort transfers with 0 byte limits

2015-09-16 Thread John Snow
On 09/16/2015 11:09 AM, Markus Armbruster wrote: > John Snow writes: > >> On 09/15/2015 04:06 AM, Markus Armbruster wrote: >>> John Snow writes: >>> We're supposed to abort on transfers like this, unless we fill Word 125 of our IDENTIFY data with a default transfer size, which w

Re: [Qemu-devel] [PATCH v3 1/1] atapi: abort transfers with 0 byte limits

2015-09-15 Thread John Snow
On 09/15/2015 04:06 AM, Markus Armbruster wrote: > John Snow writes: > >> We're supposed to abort on transfers like this, unless we fill >> Word 125 of our IDENTIFY data with a default transfer size, which >> we don't currently do. >> >> This is an ATA error, not a SCSI/ATAPI one. >> See ATA8-A

Re: [Qemu-devel] [PATCH v3 1/1] atapi: abort transfers with 0 byte limits

2015-09-15 Thread Markus Armbruster
John Snow writes: > We're supposed to abort on transfers like this, unless we fill > Word 125 of our IDENTIFY data with a default transfer size, which > we don't currently do. > > This is an ATA error, not a SCSI/ATAPI one. > See ATA8-ACS3 sections 7.17.6.49 or 7.21.5. Reading... yes, that's wha

[Qemu-devel] [PATCH v3 1/1] atapi: abort transfers with 0 byte limits

2015-09-14 Thread John Snow
We're supposed to abort on transfers like this, unless we fill Word 125 of our IDENTIFY data with a default transfer size, which we don't currently do. This is an ATA error, not a SCSI/ATAPI one. See ATA8-ACS3 sections 7.17.6.49 or 7.21.5. If we don't do this, QEMU will loop forever trying to tra