Re: [Qemu-devel] [PATCH v3 08/38] 9pfs: Fix CLI parsing crash on error

2018-10-17 Thread Eric Blake
On 10/17/18 2:15 AM, Greg Kurz wrote: On Tue, 16 Oct 2018 19:41:28 +0200 Markus Armbruster wrote: Calling error_report() in a function that takes an Error ** argument is suspicious. 9p-handle.c's handle_parse_opts() does that, and then fails without setting an error. Wrong. Its caller crash

Re: [Qemu-devel] [PATCH v3 08/38] 9pfs: Fix CLI parsing crash on error

2018-10-17 Thread Markus Armbruster
Greg Kurz writes: > On Tue, 16 Oct 2018 19:41:28 +0200 > Markus Armbruster wrote: > >> Calling error_report() in a function that takes an Error ** argument >> is suspicious. 9p-handle.c's handle_parse_opts() does that, and then >> fails without setting an error. Wrong. Its caller crashes when

Re: [Qemu-devel] [PATCH v3 08/38] 9pfs: Fix CLI parsing crash on error

2018-10-17 Thread Greg Kurz
On Tue, 16 Oct 2018 19:41:28 +0200 Markus Armbruster wrote: > Calling error_report() in a function that takes an Error ** argument > is suspicious. 9p-handle.c's handle_parse_opts() does that, and then > fails without setting an error. Wrong. Its caller crashes when it > tries to report the er

[Qemu-devel] [PATCH v3 08/38] 9pfs: Fix CLI parsing crash on error

2018-10-16 Thread Markus Armbruster
Calling error_report() in a function that takes an Error ** argument is suspicious. 9p-handle.c's handle_parse_opts() does that, and then fails without setting an error. Wrong. Its caller crashes when it tries to report the error: $ qemu-system-x86_64 -nodefaults -fsdev id=foo,fsdriver=hand