Re: [Qemu-devel] [PATCH v3 08/23] ui/vnc: Use gcrypto_random_bytes for start_auth_vnc

2019-04-11 Thread Philippe Mathieu-Daudé
On 3/15/19 4:26 AM, Richard Henderson wrote: > Use a better interface for random numbers than rand(). > Fail gracefully if for some reason we cannot use the crypto system. > > Cc: Gerd Hoffmann > Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé > --- > v2: Use qcrypto_rand

Re: [Qemu-devel] [PATCH v3 08/23] ui/vnc: Use gcrypto_random_bytes for start_auth_vnc

2019-03-15 Thread Daniel P . Berrangé
On Thu, Mar 14, 2019 at 08:26:14PM -0700, Richard Henderson wrote: > Use a better interface for random numbers than rand(). > Fail gracefully if for some reason we cannot use the crypto system. > > Cc: Gerd Hoffmann > Signed-off-by: Richard Henderson > --- > v2: Use qcrypto_random_bytes, not qem

Re: [Qemu-devel] [PATCH v3 08/23] ui/vnc: Use gcrypto_random_bytes for start_auth_vnc

2019-03-15 Thread Gerd Hoffmann
On Thu, Mar 14, 2019 at 08:26:14PM -0700, Richard Henderson wrote: > Use a better interface for random numbers than rand(). > Fail gracefully if for some reason we cannot use the crypto system. > > Cc: Gerd Hoffmann > Signed-off-by: Richard Henderson > --- > v2: Use qcrypto_random_bytes, not qem

[Qemu-devel] [PATCH v3 08/23] ui/vnc: Use gcrypto_random_bytes for start_auth_vnc

2019-03-14 Thread Richard Henderson
Use a better interface for random numbers than rand(). Fail gracefully if for some reason we cannot use the crypto system. Cc: Gerd Hoffmann Signed-off-by: Richard Henderson --- v2: Use qcrypto_random_bytes, not qemu_getrandom, as there is no need for deterministic results for this interface