Re: [Qemu-devel] [PATCH v3 08/20] tcg-arm: Implement deposit for armv7

2013-03-28 Thread Peter Maydell
On 28 March 2013 16:22, Richard Henderson wrote: > On 03/28/2013 09:15 AM, Peter Maydell wrote: >> What guarantees us that we won't see a length of 0? >> The tcg/README description doesn't say that's invalid >> and I don't think the optimize pass handles it (maybe I >> missed it). > > We can patch

Re: [Qemu-devel] [PATCH v3 08/20] tcg-arm: Implement deposit for armv7

2013-03-28 Thread Richard Henderson
On 03/28/2013 09:15 AM, Peter Maydell wrote: >> +/* ??? Without bfi, we could improve over generic code by combining >> + the right-shift from a non-zero ofs with the orr. We do run into >> + problems when rd == rs, and the mask generated from ofs+len don't >> + fit into an i

Re: [Qemu-devel] [PATCH v3 08/20] tcg-arm: Implement deposit for armv7

2013-03-28 Thread Peter Maydell
On 28 March 2013 15:32, Richard Henderson wrote: > We have BFI and BFC available for implementing it. > > Signed-off-by: Richard Henderson > --- > tcg/arm/tcg-target.c | 36 > tcg/arm/tcg-target.h | 5 - > 2 files changed, 40 insertions(+), 1 deletion(-)

[Qemu-devel] [PATCH v3 08/20] tcg-arm: Implement deposit for armv7

2013-03-28 Thread Richard Henderson
We have BFI and BFC available for implementing it. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 36 tcg/arm/tcg-target.h | 5 - 2 files changed, 40 insertions(+), 1 deletion(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c inde