Re: [Qemu-devel] [PATCH v3 06/46] ivshmem: remove unnecessary dup()

2015-09-22 Thread Marc-André Lureau
Hi - Original Message - > On 15.09.2015 18:07, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > qemu_chr_fe_get_msgfd() transfers ownership, there is no need to dup the > > fd. > > > > Are you sure? (tested?) > There is a specific comment that the dup is done beca

Re: [Qemu-devel] [PATCH v3 06/46] ivshmem: remove unnecessary dup()

2015-09-22 Thread Claudio Fontana
On 15.09.2015 18:07, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > qemu_chr_fe_get_msgfd() transfers ownership, there is no need to dup the > fd. > Are you sure? (tested?) There is a specific comment that the dup is done because of the get_msgfds implementation, I checked tc

[Qemu-devel] [PATCH v3 06/46] ivshmem: remove unnecessary dup()

2015-09-15 Thread marcandre . lureau
From: Marc-André Lureau qemu_chr_fe_get_msgfd() transfers ownership, there is no need to dup the fd. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 21 ++--- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index dd1