Re: [Qemu-devel] [PATCH v3 04/11] block: Use block_job_get() in find_block_job()

2016-07-04 Thread Daniel P. Berrange
On Mon, Jul 04, 2016 at 03:23:14PM +0200, Kevin Wolf wrote: > Am 02.07.2016 um 16:02 hat Max Reitz geschrieben: > > On 01.07.2016 17:52, Alberto Garcia wrote: > > > find_block_job() looks for a block backend with a specified name, > > > checks whether it has a block job and acquires its AioContext.

Re: [Qemu-devel] [PATCH v3 04/11] block: Use block_job_get() in find_block_job()

2016-07-04 Thread Kevin Wolf
Am 02.07.2016 um 16:02 hat Max Reitz geschrieben: > On 01.07.2016 17:52, Alberto Garcia wrote: > > find_block_job() looks for a block backend with a specified name, > > checks whether it has a block job and acquires its AioContext. > > > > We want to identify jobs by their ID and not by the block

Re: [Qemu-devel] [PATCH v3 04/11] block: Use block_job_get() in find_block_job()

2016-07-04 Thread Alberto Garcia
On Sat 02 Jul 2016 04:02:11 PM CEST, Max Reitz wrote: >> +/* Get a block job using its ID and acquire its AioContext */ >> +static BlockJob *find_block_job(const char *id, AioContext **aio_context, >> Error **errp) >> { >> -BlockBackend *blk; >> -BlockDrive

Re: [Qemu-devel] [PATCH v3 04/11] block: Use block_job_get() in find_block_job()

2016-07-02 Thread Max Reitz
On 01.07.2016 17:52, Alberto Garcia wrote: > find_block_job() looks for a block backend with a specified name, > checks whether it has a block job and acquires its AioContext. > > We want to identify jobs by their ID and not by the block backend > they're attached to, so this patch ignores the bac

[Qemu-devel] [PATCH v3 04/11] block: Use block_job_get() in find_block_job()

2016-07-01 Thread Alberto Garcia
find_block_job() looks for a block backend with a specified name, checks whether it has a block job and acquires its AioContext. We want to identify jobs by their ID and not by the block backend they're attached to, so this patch ignores the backends altogether and gets the job directly. Apart fro