Re: [Qemu-devel] [PATCH v3 03/19] qemu-nbd: Sanity check partition bounds

2019-01-15 Thread Vladimir Sementsov-Ogievskiy
12.01.2019 20:57, Eric Blake wrote: > When the user requests a partition, we were using data read > from the disk as disk offsets without a bounds check. We got > lucky that even when computed offsets are out-of-bounds, > blk_pread() will gracefully catch the error later (so I don't > think a malic

Re: [Qemu-devel] [PATCH v3 03/19] qemu-nbd: Sanity check partition bounds

2019-01-15 Thread Eric Blake
On 1/15/19 12:00 PM, Richard W.M. Jones wrote: > On Sat, Jan 12, 2019 at 11:57:56AM -0600, Eric Blake wrote: >> When the user requests a partition, we were using data read >> from the disk as disk offsets without a bounds check. We got >> lucky that even when computed offsets are out-of-bounds, >>

Re: [Qemu-devel] [PATCH v3 03/19] qemu-nbd: Sanity check partition bounds

2019-01-15 Thread Richard W.M. Jones
On Sat, Jan 12, 2019 at 11:57:56AM -0600, Eric Blake wrote: > When the user requests a partition, we were using data read > from the disk as disk offsets without a bounds check. We got > lucky that even when computed offsets are out-of-bounds, > blk_pread() will gracefully catch the error later (so

Re: [Qemu-devel] [PATCH v3 03/19] qemu-nbd: Sanity check partition bounds

2019-01-15 Thread Eric Blake
On 1/15/19 10:20 AM, Vladimir Sementsov-Ogievskiy wrote: > 12.01.2019 20:57, Eric Blake wrote: >> When the user requests a partition, we were using data read >> from the disk as disk offsets without a bounds check. We got >> lucky that even when computed offsets are out-of-bounds, >> blk_pread() wi

Re: [Qemu-devel] [PATCH v3 03/19] qemu-nbd: Sanity check partition bounds

2019-01-15 Thread Vladimir Sementsov-Ogievskiy
12.01.2019 20:57, Eric Blake wrote: > When the user requests a partition, we were using data read > from the disk as disk offsets without a bounds check. We got > lucky that even when computed offsets are out-of-bounds, > blk_pread() will gracefully catch the error later (so I don't > think a malic

[Qemu-devel] [PATCH v3 03/19] qemu-nbd: Sanity check partition bounds

2019-01-12 Thread Eric Blake
When the user requests a partition, we were using data read from the disk as disk offsets without a bounds check. We got lucky that even when computed offsets are out-of-bounds, blk_pread() will gracefully catch the error later (so I don't think a malicious image can crash or exploit qemu-nbd, and