Re: [Qemu-devel] [PATCH v3 03/15] exec-all.h: revert tb_page_addr_t to target_ulong

2016-10-04 Thread Alex Bennée
Paolo Bonzini writes: > On 03/10/2016 11:32, Alex Bennée wrote: >> 1. For atomic_read/set fall back to plain access for sizeof(*ptr) > >> sizeof(void *) >> >> This would throw up warnings in ThreadSanitizer on 64-on-32 but >> practically generate the same code as before. >> >> 2. Split sizeof(*p

Re: [Qemu-devel] [PATCH v3 03/15] exec-all.h: revert tb_page_addr_t to target_ulong

2016-10-03 Thread Alex Bennée
Emilio G. Cota writes: > On Mon, Oct 03, 2016 at 10:32:55 +0100, Alex Bennée wrote: > (snip) >> However the series as a whole does have value. As you can see from the >> other patches there are some real races being picked up by the sanitizer >> which only really become visible when a) you remov

Re: [Qemu-devel] [PATCH v3 03/15] exec-all.h: revert tb_page_addr_t to target_ulong

2016-10-03 Thread Emilio G. Cota
On Mon, Oct 03, 2016 at 10:32:55 +0100, Alex Bennée wrote: (snip) > However the series as a whole does have value. As you can see from the > other patches there are some real races being picked up by the sanitizer > which only really become visible when a) you remove the noise of the > "false" posi

Re: [Qemu-devel] [PATCH v3 03/15] exec-all.h: revert tb_page_addr_t to target_ulong

2016-10-03 Thread Paolo Bonzini
On 03/10/2016 11:32, Alex Bennée wrote: > 1. For atomic_read/set fall back to plain access for sizeof(*ptr) > > sizeof(void *) > > This would throw up warnings in ThreadSanitizer on 64-on-32 but > practically generate the same code as before. > > 2. Split sizeof(*ptr) > sizeof(void *) accesses

Re: [Qemu-devel] [PATCH v3 03/15] exec-all.h: revert tb_page_addr_t to target_ulong

2016-10-03 Thread Alex Bennée
Paolo Bonzini writes: > On 30/09/2016 23:30, Alex Bennée wrote: >> Commit b480d9b74 converted tb_page_addr_t to abi_ulong which while the >> right size imposes additional alignment restrictions on the type. This >> gets in the way of using atomic accesses on certain guest platforms >> which allo

Re: [Qemu-devel] [PATCH v3 03/15] exec-all.h: revert tb_page_addr_t to target_ulong

2016-10-03 Thread Paolo Bonzini
On 30/09/2016 23:30, Alex Bennée wrote: > Commit b480d9b74 converted tb_page_addr_t to abi_ulong which while the > right size imposes additional alignment restrictions on the type. This > gets in the way of using atomic accesses on certain guest platforms > which allow finer alignments. As tb_pag

[Qemu-devel] [PATCH v3 03/15] exec-all.h: revert tb_page_addr_t to target_ulong

2016-09-30 Thread Alex Bennée
Commit b480d9b74 converted tb_page_addr_t to abi_ulong which while the right size imposes additional alignment restrictions on the type. This gets in the way of using atomic accesses on certain guest platforms which allow finer alignments. As tb_page_addr_t isn't actually visible to the guest we ca