Re: [Qemu-devel] [PATCH v3 02/10] main-loop: switch to g_poll() on POSIX hosts

2013-02-04 Thread Paolo Bonzini
Il 04/02/2013 18:51, Fabien Chouteau ha scritto: > On 02/04/2013 06:35 PM, Paolo Bonzini wrote: >> Il 04/02/2013 16:07, Stefan Hajnoczi ha scritto: > No idea why the windows version has been mixing g_poll() and select(). > I'd hope that this series kills select() for uniformity's sake, but

Re: [Qemu-devel] [PATCH v3 02/10] main-loop: switch to g_poll() on POSIX hosts

2013-02-04 Thread Fabien Chouteau
On 02/04/2013 06:35 PM, Paolo Bonzini wrote: > Il 04/02/2013 16:07, Stefan Hajnoczi ha scritto: No idea why the windows version has been mixing g_poll() and select(). I'd hope that this series kills select() for uniformity's sake, but the 00/10 subject and the commit msg for this pat

Re: [Qemu-devel] [PATCH v3 02/10] main-loop: switch to g_poll() on POSIX hosts

2013-02-04 Thread Paolo Bonzini
Il 04/02/2013 16:07, Stefan Hajnoczi ha scritto: >> > No idea why the windows version has been mixing g_poll() and select(). >> > I'd hope that this series kills select() for uniformity's sake, but the >> > 00/10 subject and the commit msg for this patch indicate otherwise. > This is why I CCed Fab

Re: [Qemu-devel] [PATCH v3 02/10] main-loop: switch to g_poll() on POSIX hosts

2013-02-04 Thread Laszlo Ersek
On 02/04/13 16:07, Stefan Hajnoczi wrote: > slirp uses OOB because it implements TCP. I don't think we can drop it. I considered slirp for that reason, and I did grep the tree for OOB and saw some hits. I didn't track it down but I thought slirp would use lower level sockets (SOCK_RAW?) for the

Re: [Qemu-devel] [PATCH v3 02/10] main-loop: switch to g_poll() on POSIX hosts

2013-02-04 Thread Stefan Hajnoczi
On Mon, Feb 04, 2013 at 03:37:39PM +0100, Laszlo Ersek wrote: > I assume this is complex because the pre-patch situation is overly > complex as well: > > slirp -> fd_set > iohandler -> fd_set > unix

Re: [Qemu-devel] [PATCH v3 02/10] main-loop: switch to g_poll() on POSIX hosts

2013-02-04 Thread Laszlo Ersek
Comments in-line. On 02/04/13 13:12, Stefan Hajnoczi wrote: > Use g_poll(3) instead of select(2). Well, this is kind of a cheat. > It's true that we're now using g_poll(3) on POSIX hosts but the *_fill() > and *_poll() functions are still using rfds/wfds/xfds. > > We've set the scene to start con

[Qemu-devel] [PATCH v3 02/10] main-loop: switch to g_poll() on POSIX hosts

2013-02-04 Thread Stefan Hajnoczi
Use g_poll(3) instead of select(2). Well, this is kind of a cheat. It's true that we're now using g_poll(3) on POSIX hosts but the *_fill() and *_poll() functions are still using rfds/wfds/xfds. We've set the scene to start converting *_fill() and *_poll() functions step-by-step until no more rfd