Re: [Qemu-devel] [PATCH v3 01/33] Create Resettable QOM interface

2019-08-12 Thread David Gibson
On Thu, Aug 01, 2019 at 11:35:20AM +0200, Damien Hedde wrote: > > > On 7/31/19 7:46 AM, David Gibson wrote: > > On Tue, Jul 30, 2019 at 04:08:59PM +0200, Damien Hedde wrote: > >> > >> On 7/30/19 3:59 PM, Peter Maydell wrote: > >>> On Tue, 30 Jul 2019 at 14:56, Cornelia Huck wrote: > >

Re: [Qemu-devel] [PATCH v3 01/33] Create Resettable QOM interface

2019-08-07 Thread Damien Hedde
On 8/7/19 4:20 PM, Peter Maydell wrote: > On Mon, 29 Jul 2019 at 15:58, Damien Hedde wrote: >> >> This commit defines an interface allowing multi-phase reset. >> The phases are INIT, HOLD and EXIT. Each phase has an associated method >> in the class. >> >> The reset of a Resettable is controlle

Re: [Qemu-devel] [PATCH v3 01/33] Create Resettable QOM interface

2019-08-07 Thread Peter Maydell
On Mon, 29 Jul 2019 at 15:58, Damien Hedde wrote: > > This commit defines an interface allowing multi-phase reset. > The phases are INIT, HOLD and EXIT. Each phase has an associated method > in the class. > > The reset of a Resettable is controlled with 2 functions: > - resettable_assert_reset w

Re: [Qemu-devel] [PATCH v3 01/33] Create Resettable QOM interface

2019-08-01 Thread Damien Hedde
On 7/31/19 7:46 AM, David Gibson wrote: > On Tue, Jul 30, 2019 at 04:08:59PM +0200, Damien Hedde wrote: >> >> On 7/30/19 3:59 PM, Peter Maydell wrote: >>> On Tue, 30 Jul 2019 at 14:56, Cornelia Huck wrote: On Tue, 30 Jul 2019 14:44:21 +0100 Peter Maydell wrote: > On Tue

Re: [Qemu-devel] [PATCH v3 01/33] Create Resettable QOM interface

2019-08-01 Thread Christophe de Dinechin
> On 1 Aug 2019, at 11:19, Damien Hedde wrote: > > > On 7/31/19 12:17 PM, Christophe de Dinechin wrote: >> >> Peter Maydell writes: >> >>> On Tue, 30 Jul 2019 at 14:56, Cornelia Huck wrote: On Tue, 30 Jul 2019 14:44:21 +0100 Peter Maydell wrote: > On Tue, 30 Jul

Re: [Qemu-devel] [PATCH v3 01/33] Create Resettable QOM interface

2019-08-01 Thread Damien Hedde
On 7/31/19 12:17 PM, Christophe de Dinechin wrote: > > Peter Maydell writes: > >> On Tue, 30 Jul 2019 at 14:56, Cornelia Huck wrote: >>> >>> On Tue, 30 Jul 2019 14:44:21 +0100 >>> Peter Maydell wrote: >>> On Tue, 30 Jul 2019 at 14:42, Cornelia Huck wrote: > I'm having a hard time fi

Re: [Qemu-devel] [PATCH v3 01/33] Create Resettable QOM interface

2019-07-31 Thread Christophe de Dinechin
Peter Maydell writes: > On Tue, 30 Jul 2019 at 14:56, Cornelia Huck wrote: >> >> On Tue, 30 Jul 2019 14:44:21 +0100 >> Peter Maydell wrote: >> >> > On Tue, 30 Jul 2019 at 14:42, Cornelia Huck wrote: >> > > I'm having a hard time figuring out what a 'cold' or a 'warm' reset is >> > > supposed

Re: [Qemu-devel] [PATCH v3 01/33] Create Resettable QOM interface

2019-07-30 Thread David Gibson
On Tue, Jul 30, 2019 at 04:08:59PM +0200, Damien Hedde wrote: > > On 7/30/19 3:59 PM, Peter Maydell wrote: > > On Tue, 30 Jul 2019 at 14:56, Cornelia Huck wrote: > >> > >> On Tue, 30 Jul 2019 14:44:21 +0100 > >> Peter Maydell wrote: > >> > >>> On Tue, 30 Jul 2019 at 14:42, Cornelia Huck wrote:

Re: [Qemu-devel] [PATCH v3 01/33] Create Resettable QOM interface

2019-07-30 Thread Cornelia Huck
On Tue, 30 Jul 2019 16:08:59 +0200 Damien Hedde wrote: > On 7/30/19 3:59 PM, Peter Maydell wrote: > > On Tue, 30 Jul 2019 at 14:56, Cornelia Huck wrote: > >> > >> On Tue, 30 Jul 2019 14:44:21 +0100 > >> Peter Maydell wrote: > >> > >>> On Tue, 30 Jul 2019 at 14:42, Cornelia Huck wrote: >

Re: [Qemu-devel] [PATCH v3 01/33] Create Resettable QOM interface

2019-07-30 Thread Damien Hedde
On 7/30/19 3:59 PM, Peter Maydell wrote: > On Tue, 30 Jul 2019 at 14:56, Cornelia Huck wrote: >> >> On Tue, 30 Jul 2019 14:44:21 +0100 >> Peter Maydell wrote: >> >>> On Tue, 30 Jul 2019 at 14:42, Cornelia Huck wrote: I'm having a hard time figuring out what a 'cold' or a 'warm' reset is >

Re: [Qemu-devel] [PATCH v3 01/33] Create Resettable QOM interface

2019-07-30 Thread Peter Maydell
On Tue, 30 Jul 2019 at 14:56, Cornelia Huck wrote: > > On Tue, 30 Jul 2019 14:44:21 +0100 > Peter Maydell wrote: > > > On Tue, 30 Jul 2019 at 14:42, Cornelia Huck wrote: > > > I'm having a hard time figuring out what a 'cold' or a 'warm' reset is > > > supposed to be... can you add a definition/

Re: [Qemu-devel] [PATCH v3 01/33] Create Resettable QOM interface

2019-07-30 Thread Cornelia Huck
On Tue, 30 Jul 2019 14:44:21 +0100 Peter Maydell wrote: > On Tue, 30 Jul 2019 at 14:42, Cornelia Huck wrote: > > > > On Mon, 29 Jul 2019 16:56:22 +0200 > > Damien Hedde wrote: > > > > (...) > > > > > +/* > > > + * ResettableClass: > > > + * Interface for resettable objects. > > > + * > > > +

Re: [Qemu-devel] [PATCH v3 01/33] Create Resettable QOM interface

2019-07-30 Thread Peter Maydell
On Tue, 30 Jul 2019 at 14:42, Cornelia Huck wrote: > > On Mon, 29 Jul 2019 16:56:22 +0200 > Damien Hedde wrote: > > (...) > > > +/* > > + * ResettableClass: > > + * Interface for resettable objects. > > + * > > + * The reset operation is divided in several phases each represented by a > > + * met

Re: [Qemu-devel] [PATCH v3 01/33] Create Resettable QOM interface

2019-07-30 Thread Cornelia Huck
On Mon, 29 Jul 2019 16:56:22 +0200 Damien Hedde wrote: (...) > +/* > + * ResettableClass: > + * Interface for resettable objects. > + * > + * The reset operation is divided in several phases each represented by a > + * method. > + * > + * Each Ressetable must maintain a reset counter in its stat

[Qemu-devel] [PATCH v3 01/33] Create Resettable QOM interface

2019-07-29 Thread Damien Hedde
This commit defines an interface allowing multi-phase reset. The phases are INIT, HOLD and EXIT. Each phase has an associated method in the class. The reset of a Resettable is controlled with 2 functions: - resettable_assert_reset which starts the reset operation. - resettable_deassert_reset w