Re: [Qemu-devel] [PATCH v3 01/16] fdc: move object structures to header file

2018-01-04 Thread Hervé Poussineau
Le 04/01/2018 à 14:11, Marcel Apfelbaum a écrit : On 29/12/2017 16:29, Hervé Poussineau wrote: We are now able to embed floppy controllers in another object. Hi Hervé, Are you sure we need to move all the struct definitions to the header file? I looked at patch 11/16 and it seems only FDCtr

Re: [Qemu-devel] [PATCH v3 01/16] fdc: move object structures to header file

2018-01-04 Thread Marcel Apfelbaum
On 29/12/2017 16:29, Hervé Poussineau wrote: We are now able to embed floppy controllers in another object. Hi Hervé, Are you sure we need to move all the struct definitions to the header file? I looked at patch 11/16 and it seems only FDCtrlISABus definition is needed. And also only the typ

[Qemu-devel] [PATCH v3 01/16] fdc: move object structures to header file

2017-12-29 Thread Hervé Poussineau
We are now able to embed floppy controllers in another object. Signed-off-by: Hervé Poussineau --- hw/block/fdc.c | 102 include/hw/block/fdc.h | 103 + 2 files changed, 103 insertions(+), 10