Re: [Qemu-devel] [PATCH v3 01/13] pc: acpi: x2APIC support for MADT table

2016-10-18 Thread Igor Mammedov
On Tue, 18 Oct 2016 11:05:47 -0200 Eduardo Habkost wrote: > On Tue, Oct 18, 2016 at 10:47:02AM -0200, Eduardo Habkost wrote: > > On Thu, Oct 13, 2016 at 11:52:35AM +0200, Igor Mammedov wrote: > > > Signed-off-by: Igor Mammedov > > > > Reviewed-by: Eduardo Habkost > > Reviewed-by withdra

Re: [Qemu-devel] [PATCH v3 01/13] pc: acpi: x2APIC support for MADT table

2016-10-18 Thread Eduardo Habkost
On Tue, Oct 18, 2016 at 10:47:02AM -0200, Eduardo Habkost wrote: > On Thu, Oct 13, 2016 at 11:52:35AM +0200, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > Reviewed-by: Eduardo Habkost Reviewed-by withdrawn. See below: [...] > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build

Re: [Qemu-devel] [PATCH v3 01/13] pc: acpi: x2APIC support for MADT table

2016-10-18 Thread Igor Mammedov
On Tue, 18 Oct 2016 10:47:02 -0200 Eduardo Habkost wrote: > On Thu, Oct 13, 2016 at 11:52:35AM +0200, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > Reviewed-by: Eduardo Habkost > > But I have a few questions below that are not directly related to > this patch: > > > --- > > in

Re: [Qemu-devel] [PATCH v3 01/13] pc: acpi: x2APIC support for MADT table

2016-10-18 Thread Eduardo Habkost
On Thu, Oct 13, 2016 at 11:52:35AM +0200, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost But I have a few questions below that are not directly related to this patch: > --- > include/hw/acpi/acpi-defs.h | 18 +++ > hw/i386/acpi-build.c| 78 >

[Qemu-devel] [PATCH v3 01/13] pc: acpi: x2APIC support for MADT table

2016-10-13 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- include/hw/acpi/acpi-defs.h | 18 +++ hw/i386/acpi-build.c| 78 +++-- 2 files changed, 72 insertions(+), 24 deletions(-) diff --git a/include/hw/acpi/acpi-defs.h b/include/hw/acpi/acpi-defs.h index 9c1b7cb..