Re: [Qemu-devel] [PATCH v3 01/12] docs/cpu-hotplug.rst: Fix rST markup issues

2019-03-07 Thread Cleber Rosa
On Thu, Mar 07, 2019 at 09:47:18AM +, Peter Maydell wrote: > On Thu, 7 Mar 2019 at 00:04, Cleber Rosa wrote: > > But I'm assuming the extended sphinx roles/directives will be used, so > > the only way to check against future breakage would be to build the > > docs. > > > > Do we have strong po

Re: [Qemu-devel] [PATCH v3 01/12] docs/cpu-hotplug.rst: Fix rST markup issues

2019-03-07 Thread Peter Maydell
On Thu, 7 Mar 2019 at 00:04, Cleber Rosa wrote: > But I'm assuming the extended sphinx roles/directives will be used, so > the only way to check against future breakage would be to build the > docs. > > Do we have strong position in favor or against putting that into the > "common" `make check` fl

Re: [Qemu-devel] [PATCH v3 01/12] docs/cpu-hotplug.rst: Fix rST markup issues

2019-03-06 Thread Cleber Rosa
On Tue, Mar 05, 2019 at 05:21:28PM +, Peter Maydell wrote: > sphinx-build complains: > > docs/cpu-hotplug.rst:67: ERROR: Unexpected indentation. > docs/cpu-hotplug.rst:69: ERROR: Unexpected indentation. > docs/cpu-hotplug.rst:74: WARNING: Block quote ends without a blank line; > unexpected un

Re: [Qemu-devel] [PATCH v3 01/12] docs/cpu-hotplug.rst: Fix rST markup issues

2019-03-05 Thread Richard Henderson
On 3/5/19 9:21 AM, Peter Maydell wrote: > sphinx-build complains: > > docs/cpu-hotplug.rst:67: ERROR: Unexpected indentation. > docs/cpu-hotplug.rst:69: ERROR: Unexpected indentation. > docs/cpu-hotplug.rst:74: WARNING: Block quote ends without a blank line; > unexpected unindent. > docs/cpu-hotp

[Qemu-devel] [PATCH v3 01/12] docs/cpu-hotplug.rst: Fix rST markup issues

2019-03-05 Thread Peter Maydell
sphinx-build complains: docs/cpu-hotplug.rst:67: ERROR: Unexpected indentation. docs/cpu-hotplug.rst:69: ERROR: Unexpected indentation. docs/cpu-hotplug.rst:74: WARNING: Block quote ends without a blank line; unexpected unindent. docs/cpu-hotplug.rst:75: WARNING: Block quote ends without a blank