Re: [Qemu-devel] [PATCH v3 00/17] tcg: tb_lock removal redux v3

2018-06-14 Thread Richard Henderson
On 06/14/2018 08:34 AM, Alex Bennée wrote: >>> You can fetch v4 from: >>> https://github.com/cota/qemu/tree/tb-lock-removal-redux-v4 >> >> I've just spun up v4 and it still works on aarch64 and now also passes >> the coldfire test rich passed me. So have a: >> >> Tested-by: Alex Bennée >> >> For

Re: [Qemu-devel] [PATCH v3 00/17] tcg: tb_lock removal redux v3

2018-06-14 Thread Alex Bennée
Alex Bennée writes: > Emilio G. Cota writes: > >> On Wed, May 30, 2018 at 16:05:14 -0700, Richard Henderson wrote: >>> On 05/30/2018 03:46 PM, Richard Henderson wrote: >>> > Thanks. Queued to tcg-next. >>> Hmph. Unqueued, at least for now. >>> >>> ERROR:/home/rth/work/qemu/qemu/accel/tcg/tra

Re: [Qemu-devel] [PATCH v3 00/17] tcg: tb_lock removal redux v3

2018-06-02 Thread Alex Bennée
Emilio G. Cota writes: > On Wed, May 30, 2018 at 16:05:14 -0700, Richard Henderson wrote: >> On 05/30/2018 03:46 PM, Richard Henderson wrote: >> > Thanks. Queued to tcg-next. >> Hmph. Unqueued, at least for now. >> >> ERROR:/home/rth/work/qemu/qemu/accel/tcg/translate-all.c:615:page_unlock__d

Re: [Qemu-devel] [PATCH v3 00/17] tcg: tb_lock removal redux v3

2018-06-01 Thread Emilio G. Cota
On Wed, May 30, 2018 at 16:05:14 -0700, Richard Henderson wrote: > On 05/30/2018 03:46 PM, Richard Henderson wrote: > > Thanks. Queued to tcg-next. > Hmph. Unqueued, at least for now. > > ERROR:/home/rth/work/qemu/qemu/accel/tcg/translate-all.c:615:page_unlock__debug: > assertion failed: (page_i

Re: [Qemu-devel] [PATCH v3 00/17] tcg: tb_lock removal redux v3

2018-06-01 Thread Alex Bennée
Emilio G. Cota writes: > v2: https://lists.nongnu.org/archive/html/qemu-devel/2018-04/msg00656.html > I'm sure you've seen something similar but currently my profile looks like this: 5.91% qemu-system-aar qemu-system-aarch64 [.] cpu_get_tb_cpu_state 5.88% qemu-system-aar qemu-s

Re: [Qemu-devel] [PATCH v3 00/17] tcg: tb_lock removal redux v3

2018-06-01 Thread Richard Henderson
On 06/01/2018 02:32 AM, Alex Bennée wrote: >> I can invoke similar crashes with just about every image I try. > > Just booting up? Not even very far into the boot, and given that I can see it with coldfire, even without -smp. r~

Re: [Qemu-devel] [PATCH v3 00/17] tcg: tb_lock removal redux v3

2018-06-01 Thread Alex Bennée
Richard Henderson writes: > On 05/30/2018 03:46 PM, Richard Henderson wrote: >> Thanks. Queued to tcg-next. > Hmph. Unqueued, at least for now. > > ERROR:/home/rth/work/qemu/qemu/accel/tcg/translate-all.c:615:page_unlock__debug: > assertion failed: (page_is_locked(pd)) > > #3 0x74b69

Re: [Qemu-devel] [PATCH v3 00/17] tcg: tb_lock removal redux v3

2018-05-30 Thread Richard Henderson
On 05/30/2018 03:46 PM, Richard Henderson wrote: > Thanks. Queued to tcg-next. Hmph. Unqueued, at least for now. ERROR:/home/rth/work/qemu/qemu/accel/tcg/translate-all.c:615:page_unlock__debug: assertion failed: (page_is_locked(pd)) #3 0x74b6915e in g_assertion_message_expr () at /

Re: [Qemu-devel] [PATCH v3 00/17] tcg: tb_lock removal redux v3

2018-05-30 Thread Richard Henderson
On 05/21/2018 04:39 PM, Emilio G. Cota wrote: > v2: https://lists.nongnu.org/archive/html/qemu-devel/2018-04/msg00656.html > > Changes since v2: > > - rebase onto master, fixing conflicts > > - add R-b's > > - add a missing page_lock to page_collection_lock > > - add a couple of missing assert

[Qemu-devel] [PATCH v3 00/17] tcg: tb_lock removal redux v3

2018-05-21 Thread Emilio G. Cota
v2: https://lists.nongnu.org/archive/html/qemu-devel/2018-04/msg00656.html Changes since v2: - rebase onto master, fixing conflicts - add R-b's - add a missing page_lock to page_collection_lock - add a couple of missing assert_page_locked assertions - add page_lock_pair, as suggested by Alex