Re: [Qemu-devel] [PATCH v3 0/9] block: Fixes for bdrv_drain

2015-11-09 Thread Fam Zheng
On Mon, 11/09 11:42, Stefan Hajnoczi wrote: > On Mon, Nov 09, 2015 at 10:56:39AM +0800, Fam Zheng wrote: > > v3: Don't reuse coroutine in bdrv_aio_ioctl. [Stefan] > > Recursely call .bdrv_drain callback only. [Stefan, Paolo] > > I don't understand this change. I thought you want .bdrv_drain()

Re: [Qemu-devel] [PATCH v3 0/9] block: Fixes for bdrv_drain

2015-11-09 Thread Stefan Hajnoczi
On Mon, Nov 09, 2015 at 10:56:39AM +0800, Fam Zheng wrote: > v3: Don't reuse coroutine in bdrv_aio_ioctl. [Stefan] > Recursely call .bdrv_drain callback only. [Stefan, Paolo] I don't understand this change. I thought you want .bdrv_drain() to be called on the whole tree, but the latest code s

[Qemu-devel] [PATCH v3 0/9] block: Fixes for bdrv_drain

2015-11-08 Thread Fam Zheng
v3: Don't reuse coroutine in bdrv_aio_ioctl. [Stefan] Recursely call .bdrv_drain callback only. [Stefan, Paolo] Added Kevin's reviewed-by in other patches. v2: Add Kevin's reviewed-by in patches 1, 2, 5-7, 9. Address Kevin's reviewing comments which are: - Explicit "ret = 0" before