Re: [Qemu-devel] [PATCH v3 0/5] Geometry and blocksize detection for backing devices.

2014-12-15 Thread Markus Armbruster
Ekaterina Tumanova writes: > This 3rd revision of the patch set. No longer applies cleanly, please rebase. Sorry for taking so long to review. Your general approach looks sound to me now. There are a few trivial bugs / inaccuracies here and there, and of course I found some nits to pick.

Re: [Qemu-devel] [PATCH v3 0/5] Geometry and blocksize detection for backing devices.

2014-12-12 Thread Ekaterina Tumanova
On 12/05/2014 08:56 PM, Ekaterina Tumanova wrote: This 3rd revision of the patch set. Proper geometry and blocksize information is vital for support of DASD/ECKD drives in Linux guests. Otherwise things will fail in certain cases. The existing geometry and blocksize qemu defaults have no sense

[Qemu-devel] [PATCH v3 0/5] Geometry and blocksize detection for backing devices.

2014-12-05 Thread Ekaterina Tumanova
This 3rd revision of the patch set. Proper geometry and blocksize information is vital for support of DASD/ECKD drives in Linux guests. Otherwise things will fail in certain cases. The existing geometry and blocksize qemu defaults have no sense for DASD drives (hd_geometry_guess detection and 512