Re: [Qemu-devel] [PATCH v3 0/4] scripts: qmp-shell: add transaction support

2015-04-29 Thread Kashyap Chamarthy
On Tue, Apr 28, 2015 at 06:17:32PM +0200, Kashyap Chamarthy wrote: [. . .] > > Seems like a regression from your v2. > > > > It fails here, even for a non-transaction command, with your patch series > > applied: > > > > (QEMU) blockdev-snapshot-internal-sync device=drive-ide0-0-0 > > name=sn

Re: [Qemu-devel] [PATCH v3 0/4] scripts: qmp-shell: add transaction support

2015-04-28 Thread John Snow
On 04/28/2015 12:17 PM, Kashyap Chamarthy wrote: On Thu, Apr 23, 2015 at 06:23:31PM +0200, Kashyap Chamarthy wrote: On Thu, Apr 23, 2015 at 10:34:57AM -0400, John Snow wrote: The qmp-shell is a little rudimentary, but it can be hacked to give us some transactional support without too much dif

Re: [Qemu-devel] [PATCH v3 0/4] scripts: qmp-shell: add transaction support

2015-04-28 Thread Kashyap Chamarthy
On Thu, Apr 23, 2015 at 06:23:31PM +0200, Kashyap Chamarthy wrote: > On Thu, Apr 23, 2015 at 10:34:57AM -0400, John Snow wrote: > > The qmp-shell is a little rudimentary, but it can be hacked > > to give us some transactional support without too much difficulty. > > > > (1) Prep. > > (2) Add suppo

Re: [Qemu-devel] [PATCH v3 0/4] scripts: qmp-shell: add transaction support

2015-04-23 Thread Kashyap Chamarthy
On Thu, Apr 23, 2015 at 10:34:57AM -0400, John Snow wrote: > The qmp-shell is a little rudimentary, but it can be hacked > to give us some transactional support without too much difficulty. > > (1) Prep. > (2) Add support for serializing json arrays > (3) Allow users to use 'single quotes' instead

Re: [Qemu-devel] [PATCH v3 0/4] scripts: qmp-shell: add transaction support

2015-04-23 Thread John Snow
On 04/23/2015 10:34 AM, John Snow wrote: The qmp-shell is a little rudimentary, but it can be hacked to give us some transactional support without too much difficulty. (1) Prep. (2) Add support for serializing json arrays (3) Allow users to use 'single quotes' instead of "double quotes" (4) Ad

[Qemu-devel] [PATCH v3 0/4] scripts: qmp-shell: add transaction support

2015-04-23 Thread John Snow
The qmp-shell is a little rudimentary, but it can be hacked to give us some transactional support without too much difficulty. (1) Prep. (2) Add support for serializing json arrays (3) Allow users to use 'single quotes' instead of "double quotes" (4) Add a special transaction( ... ) syntax that le