Re: [Qemu-devel] [PATCH v3 0/3] use object link instead of qdev property

2018-10-22 Thread maozy
Hi, Gerd On 10/19/18 4:04 PM, Gerd Hoffmann wrote: On Mon, Oct 15, 2018 at 11:26:39AM +0800, Mao Zhongyi wrote: According to qdev-properties.h, properties of pointer type should be avoid, so convert qdev property to link, Whilst we are here, also update some hardcoded strings with already defin

Re: [Qemu-devel] [PATCH v3 0/3] use object link instead of qdev property

2018-10-19 Thread Gerd Hoffmann
On Mon, Oct 15, 2018 at 11:26:39AM +0800, Mao Zhongyi wrote: > According to qdev-properties.h, properties of pointer type > should be avoid, so convert qdev property to link, Whilst we > are here, also update some hardcoded strings with already > defineded macros. Patch series breaks "make check".

[Qemu-devel] [PATCH v3 0/3] use object link instead of qdev property

2018-10-14 Thread Mao Zhongyi
According to qdev-properties.h, properties of pointer type should be avoid, so convert qdev property to link, Whilst we are here, also update some hardcoded strings with already defineded macros. v3: -removed incorrected "To: xxx" tags from commit message -keep 'dc->user_creatable = false' in mv88