Re: [Qemu-devel] [PATCH v3] virtio-pci: fix migration for pci bus master

2014-10-21 Thread Greg Kurz
On Tue, 21 Oct 2014 15:10:22 +0300 "Michael S. Tsirkin" wrote: > On Tue, Oct 21, 2014 at 01:35:39PM +0200, Alexander Graf wrote: > > > > > > On 21.10.14 12:16, Michael S. Tsirkin wrote: > > > On Mon, Oct 20, 2014 at 06:08:56PM +0200, Alexander Graf wrote: > > >> > > >> > > >> On 20.10.14 08:58,

Re: [Qemu-devel] [PATCH v3] virtio-pci: fix migration for pci bus master

2014-10-21 Thread Alexander Graf
On 21.10.14 14:10, Michael S. Tsirkin wrote: > On Tue, Oct 21, 2014 at 01:35:39PM +0200, Alexander Graf wrote: >> >> >> On 21.10.14 12:16, Michael S. Tsirkin wrote: >>> On Mon, Oct 20, 2014 at 06:08:56PM +0200, Alexander Graf wrote: On 20.10.14 08:58, Michael S. Tsirkin wrote:

Re: [Qemu-devel] [PATCH v3] virtio-pci: fix migration for pci bus master

2014-10-21 Thread Michael S. Tsirkin
On Tue, Oct 21, 2014 at 01:35:39PM +0200, Alexander Graf wrote: > > > On 21.10.14 12:16, Michael S. Tsirkin wrote: > > On Mon, Oct 20, 2014 at 06:08:56PM +0200, Alexander Graf wrote: > >> > >> > >> On 20.10.14 08:58, Michael S. Tsirkin wrote: > >>> Current support for bus master (clearing OK bit)

Re: [Qemu-devel] [PATCH v3] virtio-pci: fix migration for pci bus master

2014-10-21 Thread Alexander Graf
On 21.10.14 12:16, Michael S. Tsirkin wrote: > On Mon, Oct 20, 2014 at 06:08:56PM +0200, Alexander Graf wrote: >> >> >> On 20.10.14 08:58, Michael S. Tsirkin wrote: >>> Current support for bus master (clearing OK bit) together with the need to >>> support guests which do not enable PCI bus master

Re: [Qemu-devel] [PATCH v3] virtio-pci: fix migration for pci bus master

2014-10-21 Thread Michael S. Tsirkin
On Mon, Oct 20, 2014 at 06:08:56PM +0200, Alexander Graf wrote: > > > On 20.10.14 08:58, Michael S. Tsirkin wrote: > > Current support for bus master (clearing OK bit) together with the need to > > support guests which do not enable PCI bus mastering, leads to extra state > > in > > VIRTIO_PCI_F

Re: [Qemu-devel] [PATCH v3] virtio-pci: fix migration for pci bus master

2014-10-20 Thread Greg Kurz
On Mon, 20 Oct 2014 18:08:56 +0200 Alexander Graf wrote: > > > On 20.10.14 08:58, Michael S. Tsirkin wrote: > > Current support for bus master (clearing OK bit) together with the need to > > support guests which do not enable PCI bus mastering, leads to extra state > > in > > VIRTIO_PCI_FLAG_B

Re: [Qemu-devel] [PATCH v3] virtio-pci: fix migration for pci bus master

2014-10-20 Thread Alexander Graf
On 20.10.14 08:58, Michael S. Tsirkin wrote: > Current support for bus master (clearing OK bit) together with the need to > support guests which do not enable PCI bus mastering, leads to extra state in > VIRTIO_PCI_FLAG_BUS_MASTER_BUG bit, which isn't robust in case of > cross-version > migratio

Re: [Qemu-devel] [PATCH v3] virtio-pci: fix migration for pci bus master

2014-10-20 Thread Greg Kurz
On Mon, 20 Oct 2014 09:58:50 +0300 "Michael S. Tsirkin" wrote: > Current support for bus master (clearing OK bit) together with the need to > support guests which do not enable PCI bus mastering, leads to extra state in > VIRTIO_PCI_FLAG_BUS_MASTER_BUG bit, which isn't robust in case of > cross-v

[Qemu-devel] [PATCH v3] virtio-pci: fix migration for pci bus master

2014-10-19 Thread Michael S. Tsirkin
Current support for bus master (clearing OK bit) together with the need to support guests which do not enable PCI bus mastering, leads to extra state in VIRTIO_PCI_FLAG_BUS_MASTER_BUG bit, which isn't robust in case of cross-version migration for the case when guests use the device before setting D