Re: [Qemu-devel] [PATCH v3] virtio-9p: Use relative includes for files in hw

2011-05-28 Thread Venkateswararao Jujjuri
On 05/28/2011 09:51 AM, Aneesh Kumar K.V wrote: On Fri, 27 May 2011 20:27:11 +0200, Stefan Weil wrote: Am 29.04.2011 02:46, schrieb Peter Maydell: On 28 April 2011 21:49, Anthony Liguori wrote: On 04/28/2011 03:02 PM, Stefan Weil wrote: -$(addprefix 9pfs/, $(9pfs-nested-y)): CFLAGS += -

Re: [Qemu-devel] [PATCH v3] virtio-9p: Use relative includes for files in hw

2011-05-28 Thread Aneesh Kumar K.V
On Fri, 27 May 2011 20:27:11 +0200, Stefan Weil wrote: > Am 29.04.2011 02:46, schrieb Peter Maydell: > > On 28 April 2011 21:49, Anthony Liguori wrote: > > > >> On 04/28/2011 03:02 PM, Stefan Weil wrote: > >> > >>> -$(addprefix 9pfs/, $(9pfs-nested-y)): CFLAGS += -I$(SRC_PATH)/hw/ > >>

Re: [Qemu-devel] [PATCH v3] virtio-9p: Use relative includes for files in hw

2011-05-27 Thread Stefan Weil
Am 29.04.2011 02:46, schrieb Peter Maydell: On 28 April 2011 21:49, Anthony Liguori wrote: On 04/28/2011 03:02 PM, Stefan Weil wrote: -$(addprefix 9pfs/, $(9pfs-nested-y)): CFLAGS += -I$(SRC_PATH)/hw/ Wouldn't it be more straight forward to just do QEMU_CFLAGS +=? Th

Re: [Qemu-devel] [PATCH v3] virtio-9p: Use relative includes for files in hw

2011-04-28 Thread Peter Maydell
On 28 April 2011 21:49, Anthony Liguori wrote: > On 04/28/2011 03:02 PM, Stefan Weil wrote: >> -$(addprefix 9pfs/, $(9pfs-nested-y)): CFLAGS +=  -I$(SRC_PATH)/hw/ > > Wouldn't it be more straight forward to just do QEMU_CFLAGS +=? There aren't any other source files in QEMU which have custom incl

Re: [Qemu-devel] [PATCH v3] virtio-9p: Use relative includes for files in hw

2011-04-28 Thread Stefan Weil
Am 28.04.2011 22:49, schrieb Anthony Liguori: On 04/28/2011 03:02 PM, Stefan Weil wrote: Commit 353ac78d495ef976242abd868f68d78420861c2c moved the files without fixing the include paths. It used a modified CFLAGS to add hw to the include search path, but this breaks builds where the user wants t

Re: [Qemu-devel] [PATCH v3] virtio-9p: Use relative includes for files in hw

2011-04-28 Thread Anthony Liguori
On 04/28/2011 03:02 PM, Stefan Weil wrote: Commit 353ac78d495ef976242abd868f68d78420861c2c moved the files without fixing the include paths. It used a modified CFLAGS to add hw to the include search path, but this breaks builds where the user wants to set special CFLAGS. Long include paths also i

[Qemu-devel] [PATCH v3] virtio-9p: Use relative includes for files in hw

2011-04-28 Thread Stefan Weil
Commit 353ac78d495ef976242abd868f68d78420861c2c moved the files without fixing the include paths. It used a modified CFLAGS to add hw to the include search path, but this breaks builds where the user wants to set special CFLAGS. Long include paths also increase compilation time. Therefore this pat