Re: [Qemu-devel] [PATCH v3] usb: assign unique serial numbers to hid devices

2019-01-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190110120843.3839-1-kra...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v3] usb: assign unique serial numbers to hid devices Type: series Message-id

Re: [Qemu-devel] [PATCH v3] usb: assign unique serial numbers to hid devices

2019-01-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190110120843.3839-1-kra...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/

Re: [Qemu-devel] [PATCH v3] usb: assign unique serial numbers to hid devices

2019-01-10 Thread Daniel P . Berrangé
On Thu, Jan 10, 2019 at 01:08:43PM +0100, Gerd Hoffmann wrote: > Windows guests have trouble dealing with usb devices having identical > serial numbers. So, assign unique serial numbers to usb hid devices. > All other usb devices have this already. > > In the past the fixed serial number has been

[Qemu-devel] [PATCH v3] usb: assign unique serial numbers to hid devices

2019-01-10 Thread Gerd Hoffmann
Windows guests have trouble dealing with usb devices having identical serial numbers. So, assign unique serial numbers to usb hid devices. All other usb devices have this already. In the past the fixed serial number has been used to indicate working remote setup to linux guests. Here is a bit of