Re: [Qemu-devel] [PATCH v3] target/mips: Fix minor bug in FPU

2019-03-20 Thread Mateja Marjanovic
On 19.3.19. 23:02, Alex Bennée wrote: Aleksandar Markovic writes: From: Peter Maydell Subject: Re: [PATCH v3] target/mips: Fix minor bug in FPU On Tue, 19 Mar 2019 at 19:21, Aleksandar Markovic wrote: From: Mateja Marjanovic Subject: [PATCH v3] target/mips: Fix minor bug in FPU From: M

Re: [Qemu-devel] [PATCH v3] target/mips: Fix minor bug in FPU

2019-03-20 Thread Mateja Marjanovic
On 19.3.19. 16:27, Peter Maydell wrote: On Tue, 19 Mar 2019 at 15:22, Mateja Marjanovic wrote: From: Mateja Marjanovic Wrong type of NaN was generated for IEEE 754-2008 by MADDF. and MSUBF. instructions when the arguments were (inf, zero, nan) or (zero, inf, nan). These instructions were te

Re: [Qemu-devel] [PATCH v3] target/mips: Fix minor bug in FPU

2019-03-19 Thread Alex Bennée
Aleksandar Markovic writes: >> >> From: Peter Maydell >> Subject: Re: [PATCH v3] target/mips: Fix minor bug in FPU >> >> On Tue, 19 Mar 2019 at 19:21, Aleksandar Markovic >> wrote: >> > >> > > From: Mateja Marjanovic >> > > Subject: [PATCH v3] target/mips: Fix minor bug in FPU >> > > >> > >

Re: [Qemu-devel] [PATCH v3] target/mips: Fix minor bug in FPU

2019-03-19 Thread Aleksandar Markovic
> > From: Peter Maydell > Subject: Re: [PATCH v3] target/mips: Fix minor bug in FPU > > On Tue, 19 Mar 2019 at 19:21, Aleksandar Markovic > wrote: > > > > > From: Mateja Marjanovic > > > Subject: [PATCH v3] target/mips: Fix minor bug in FPU > > > > > > From: Mateja Marjanovic > > > > > > Wron

Re: [Qemu-devel] [PATCH v3] target/mips: Fix minor bug in FPU

2019-03-19 Thread Peter Maydell
On Tue, 19 Mar 2019 at 19:21, Aleksandar Markovic wrote: > > > From: Mateja Marjanovic > > Subject: [PATCH v3] target/mips: Fix minor bug in FPU > > > > From: Mateja Marjanovic > > > > Wrong type of NaN was generated for IEEE 754-2008 by MADDF. and > > MSUBF. instructions when the arguments were

Re: [Qemu-devel] [PATCH v3] target/mips: Fix minor bug in FPU

2019-03-19 Thread Aleksandar Markovic
> From: Mateja Marjanovic > Subject: [PATCH v3] target/mips: Fix minor bug in FPU > > From: Mateja Marjanovic > > Wrong type of NaN was generated for IEEE 754-2008 by MADDF. and > MSUBF. instructions when the arguments were (inf, zero, nan) or > (zero, inf, nan). > These instructions were teste

Re: [Qemu-devel] [PATCH v3] target/mips: Fix minor bug in FPU

2019-03-19 Thread Aleksandar Markovic
> >> From: Alex Bennée > >> Subject: Re: [PATCH v3] target/mips: Fix minor bug in FPU > >> > >> Queued to fpu/next, thanks. > > > > Alex, does this mean for 4.0 or 4.1? > > It's a bug fix so it will go in 4.0 I think. Right, Alex, I also think it should be included in 4.0. Please include this pa

Re: [Qemu-devel] [PATCH v3] target/mips: Fix minor bug in FPU

2019-03-19 Thread Alex Bennée
Aleksandar Markovic writes: >> From: Alex Bennée >> Subject: Re: [PATCH v3] target/mips: Fix minor bug in FPU >> >> Queued to fpu/next, thanks. > > Alex, does this mean for 4.0 or 4.1? It's a bug fix so it will go in 4.0 I think. -- Alex Bennée

Re: [Qemu-devel] [PATCH v3] target/mips: Fix minor bug in FPU

2019-03-19 Thread Aleksandar Markovic
> From: Alex Bennée > Subject: Re: [PATCH v3] target/mips: Fix minor bug in FPU > > Queued to fpu/next, thanks. Alex, does this mean for 4.0 or 4.1? Aleksandar

Re: [Qemu-devel] [PATCH v3] target/mips: Fix minor bug in FPU

2019-03-19 Thread Alex Bennée
Mateja Marjanovic writes: > From: Mateja Marjanovic > > Wrong type of NaN was generated for IEEE 754-2008 by MADDF. and > MSUBF. instructions when the arguments were (inf, zero, nan) or > (zero, inf, nan). > These instructions were tested and the results match with the results > of the machine

Re: [Qemu-devel] [PATCH v3] target/mips: Fix minor bug in FPU

2019-03-19 Thread Peter Maydell
On Tue, 19 Mar 2019 at 15:22, Mateja Marjanovic wrote: > > From: Mateja Marjanovic > > Wrong type of NaN was generated for IEEE 754-2008 by MADDF. and > MSUBF. instructions when the arguments were (inf, zero, nan) or > (zero, inf, nan). > These instructions were tested and the results match with

[Qemu-devel] [PATCH v3] target/mips: Fix minor bug in FPU

2019-03-19 Thread Mateja Marjanovic
From: Mateja Marjanovic Wrong type of NaN was generated for IEEE 754-2008 by MADDF. and MSUBF. instructions when the arguments were (inf, zero, nan) or (zero, inf, nan). These instructions were tested and the results match with the results of the machine that has a MIPS64 r6 cpu. Signed-off-by:

[Qemu-devel] [PATCH v3] target/mips: Fix minor bug in FPU

2019-03-19 Thread Mateja Marjanovic
From: Mateja Marjanovic The if-else statement indicates if the system conforms to IEEE 754-1985 or IEEE 754-2008, and it has different behaviour depending on that. v3: - In case of IEEE 754-1985, return the default-NaN and raise floating point exception 'Invalid Operation' [1](page 349, 350)