Re: [Qemu-devel] [PATCH v3] qmp: expose list of supported character device backends

2014-02-11 Thread Luiz Capitulino
On Sat, 1 Feb 2014 12:52:42 +0100 Martin Kletzander wrote: > Introduce 'query-chardev-backends' QMP command which lists all > supported character device backends. > > Signed-off-by: Martin Kletzander Applied to the qmp branch, thanks. > --- > v3: > - Omit commas at the end of list in JSON >

Re: [Qemu-devel] [PATCH v3] qmp: expose list of supported character device backends

2014-02-11 Thread Eric Blake
On 02/11/2014 08:51 AM, Luiz Capitulino wrote: +## +{ 'type': 'ChardevBackendInfo', 'data': {'name': 'str'} } >>> >>> We already have ChardevBackend, it's an union though. I'm wondering if >>> you could change it to an enum and use it instead of plain 'str'? >> >> and we also document i

Re: [Qemu-devel] [PATCH v3] qmp: expose list of supported character device backends

2014-02-11 Thread Luiz Capitulino
On Mon, 10 Feb 2014 14:36:20 -0700 Eric Blake wrote: > On 02/10/2014 02:16 PM, Luiz Capitulino wrote: > > On Sat, 1 Feb 2014 12:52:42 +0100 > > Martin Kletzander wrote: > > > >> Introduce 'query-chardev-backends' QMP command which lists all > >> supported character device backends. > >> > >> S

Re: [Qemu-devel] [PATCH v3] qmp: expose list of supported character device backends

2014-02-11 Thread Eric Blake
On 02/11/2014 01:32 AM, Markus Armbruster wrote: > Eric Blake writes: >> >> Hmm, right now, the ChardevBackend union pre-dates when we added flat >> unions. For flat unions, we can set a discriminator to be an enum type >> [1], at which point the code generator then validates that we cover all >

Re: [Qemu-devel] [PATCH v3] qmp: expose list of supported character device backends

2014-02-11 Thread Markus Armbruster
Eric Blake writes: > On 02/10/2014 02:16 PM, Luiz Capitulino wrote: >> On Sat, 1 Feb 2014 12:52:42 +0100 >> Martin Kletzander wrote: >> >>> Introduce 'query-chardev-backends' QMP command which lists all >>> supported character device backends. >>> >>> Signed-off-by: Martin Kletzander >>> ---

Re: [Qemu-devel] [PATCH v3] qmp: expose list of supported character device backends

2014-02-10 Thread Eric Blake
On 02/10/2014 02:16 PM, Luiz Capitulino wrote: > On Sat, 1 Feb 2014 12:52:42 +0100 > Martin Kletzander wrote: > >> Introduce 'query-chardev-backends' QMP command which lists all >> supported character device backends. >> >> Signed-off-by: Martin Kletzander >> --- >> +## >> +{ 'type': 'ChardevB

Re: [Qemu-devel] [PATCH v3] qmp: expose list of supported character device backends

2014-02-10 Thread Luiz Capitulino
On Sat, 1 Feb 2014 12:52:42 +0100 Martin Kletzander wrote: > Introduce 'query-chardev-backends' QMP command which lists all > supported character device backends. > > Signed-off-by: Martin Kletzander > --- > v3: > - Omit commas at the end of list in JSON > v2: > - Version changed from "1.8.0

Re: [Qemu-devel] [PATCH v3] qmp: expose list of supported character device backends

2014-02-03 Thread Eric Blake
On 02/01/2014 04:52 AM, Martin Kletzander wrote: > Introduce 'query-chardev-backends' QMP command which lists all > supported character device backends. > > Signed-off-by: Martin Kletzander > --- > v3: > - Omit commas at the end of list in JSON > v2: > - Version changed from "1.8.0" to "2.0" >

[Qemu-devel] [PATCH v3] qmp: expose list of supported character device backends

2014-02-01 Thread Martin Kletzander
Introduce 'query-chardev-backends' QMP command which lists all supported character device backends. Signed-off-by: Martin Kletzander --- v3: - Omit commas at the end of list in JSON v2: - Version changed from "1.8.0" to "2.0" qapi-schema.json | 22 ++ qemu-char.c | 19