Re: [Qemu-devel] [PATCH v3] qemu crashes when a negative number used for 'maxcpus'

2017-08-28 Thread Bharata B Rao
Seeteena, On Mon, Aug 28, 2017 at 7:23 PM, Seeteena Thoufeek < s1see...@linux.vnet.ibm.com> wrote: > ---Steps to Reproduce--- > > When passed a negative number to 'maxcpus' parameter, Qemu aborts > with a core dump. > > Run the following command with maxcpus argument as negative number > > ppc64-

Re: [Qemu-devel] [PATCH v3] qemu crashes when a negative number used for 'maxcpus'

2017-08-28 Thread Fam Zheng
Hi Seeteena, thanks for sending the patch and fixing the coding style! I suggest to change subject to "vl: exit if maxcpus is negative". The subject of a patch email is going to be the summary of the commit message when applied, therefore it should be worded to summarize the change. Commonly there

[Qemu-devel] [PATCH v3] qemu crashes when a negative number used for 'maxcpus'

2017-08-28 Thread Seeteena Thoufeek
---Steps to Reproduce--- When passed a negative number to 'maxcpus' parameter, Qemu aborts with a core dump. Run the following command with maxcpus argument as negative number ppc64-softmmu/qemu-system-ppc64 --nographic -vga none -machine pseries,accel=kvm,kvm-type=HV -m size=200g -device virtio