Re: [Qemu-devel] [PATCH v3] net: Transmit zero UDP checksum as 0xFFFF

2017-11-16 Thread Ed Swierk via Qemu-devel
On Wed, Nov 15, 2017 at 7:55 PM, Eric Blake wrote: > > On 11/15/2017 09:07 PM, Ed Swierk via Qemu-devel wrote: > > This part below... > > > > > v3: > > > > Leave net_tx_pkt_update_ip_checksums() alone since it's only computing > > a partial sum of the IP pseudo-header. > > > > Rename wrapper to ne

Re: [Qemu-devel] [PATCH v3] net: Transmit zero UDP checksum as 0xFFFF

2017-11-15 Thread Eric Blake
On 11/15/2017 09:07 PM, Ed Swierk via Qemu-devel wrote: [meta-comment] > The checksum algorithm used by IPv4, TCP and UDP allows a zero value > to be represented by either 0x and 0x. But per RFC 768, a zero > UDP checksum must be transmitted as 0x, as 0x is a special > value meani

[Qemu-devel] [PATCH v3] net: Transmit zero UDP checksum as 0xFFFF

2017-11-15 Thread Ed Swierk via Qemu-devel
The checksum algorithm used by IPv4, TCP and UDP allows a zero value to be represented by either 0x and 0x. But per RFC 768, a zero UDP checksum must be transmitted as 0x, as 0x is a special value meaning no checksum. Substitute 0x whenever a checksum is computed as zero when m