Re: [Qemu-devel] [PATCH v3] ide: Add resize callback to ide/core

2014-09-05 Thread Markus Armbruster
John Snow writes: > On 09/04/2014 12:13 PM, Stefan Hajnoczi wrote: >> This patch seems to break tests/bios-tables-test.c: >> ERROR:tests/bios-tables-test.c:744:test_acpi_one: assertion failed >> (signature == SIGNATURE): (0x == 0xdead) >> GTester: last random seed: R02S3d881198f35228a

Re: [Qemu-devel] [PATCH v3] ide: Add resize callback to ide/core

2014-09-04 Thread John Snow
On 09/04/2014 12:13 PM, Stefan Hajnoczi wrote: This patch seems to break tests/bios-tables-test.c: ERROR:tests/bios-tables-test.c:744:test_acpi_one: assertion failed (signature == SIGNATURE): (0x == 0xdead) GTester: last random seed: R02S3d881198f35228a485b4c3d116dff3b1 I have run

Re: [Qemu-devel] [PATCH v3] ide: Add resize callback to ide/core

2014-09-04 Thread Stefan Hajnoczi
This patch seems to break tests/bios-tables-test.c: ERROR:tests/bios-tables-test.c:744:test_acpi_one: assertion failed (signature == SIGNATURE): (0x == 0xdead) GTester: last random seed: R02S3d881198f35228a485b4c3d116dff3b1 I have run it many times to make sure the failure is determini

Re: [Qemu-devel] [PATCH v3] ide: Add resize callback to ide/core

2014-08-20 Thread Stefan Hajnoczi
On Tue, Aug 19, 2014 at 03:20:06PM -0400, John Snow wrote: > > > On 08/18/2014 09:12 AM, Stefan Hajnoczi wrote: > >On Thu, Aug 14, 2014 at 05:03:06PM -0400, John Snow wrote: > >>@@ -162,10 +173,10 @@ static void ide_identify(IDEState *s) > >> } > >> put_le16(p + 88, 0x3f | (1 << 13)); /

Re: [Qemu-devel] [PATCH v3] ide: Add resize callback to ide/core

2014-08-19 Thread John Snow
On 08/18/2014 09:12 AM, Stefan Hajnoczi wrote: On Thu, Aug 14, 2014 at 05:03:06PM -0400, John Snow wrote: @@ -162,10 +173,10 @@ static void ide_identify(IDEState *s) } put_le16(p + 88, 0x3f | (1 << 13)); /* udma5 set and supported */ put_le16(p + 93, 1 | (1 << 14) | 0x2000);

Re: [Qemu-devel] [PATCH v3] ide: Add resize callback to ide/core

2014-08-18 Thread Stefan Hajnoczi
On Thu, Aug 14, 2014 at 05:03:06PM -0400, John Snow wrote: > @@ -162,10 +173,10 @@ static void ide_identify(IDEState *s) > } > put_le16(p + 88, 0x3f | (1 << 13)); /* udma5 set and supported */ > put_le16(p + 93, 1 | (1 << 14) | 0x2000); > -put_le16(p + 100, s->nb_sectors); > -

Re: [Qemu-devel] [PATCH v3] ide: Add resize callback to ide/core

2014-08-15 Thread Markus Armbruster
John Snow writes: > Currently, if the block device backing the IDE drive is resized, > the information about the device as cached inside of the IDEState > structure is not updated, thus when a guest OS re-queries the drive, > it is unable to see the expanded size. > > This patch adds a resize cal

[Qemu-devel] [PATCH v3] ide: Add resize callback to ide/core

2014-08-14 Thread John Snow
Currently, if the block device backing the IDE drive is resized, the information about the device as cached inside of the IDEState structure is not updated, thus when a guest OS re-queries the drive, it is unable to see the expanded size. This patch adds a resize callback that updates the IDENTIFY